-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on selection on iOS versions below 14 after latest iOS 14 hotfix #78
Comments
Xcode compilation with this test fix was happening as I was filling this: if (this.SUPPORT_TEXT_COLOR) {
nativePicker.setValueForKey(color.ios, 'textColor');
} and I can confirm that this fixes the issue on iOS versions below 14 while still working under iOS 14, will make a PR ASAP ! |
@NathanWalker this issue is still there on NS 6 version of this plugin. Can you please fix it for NS 6 app as well ? |
thats odd, since I am using NS6 still, and the issue has been fixed on our end |
Weird can you double check that you are using NS6 please, and which version of the plugin you have. Im using the latest 1.2.3 and you can also see that the fix you provided in your PR has not been applied.
|
yep nevermind, the PR isn't closed yet We have a local copy of the library that we built ourselves, didn't realise it wasn't merged yet, sorry ! |
Which platform(s) does your issue occur on?
Please, provide the following version numbers that your issue occurs with:
Please, tell us how to recreate the issue in as much detail as possible.
Trying to open the datepicker was fixed in iOS 14, but the fix broke every other iOS versions apparently, we're getting a huge flood of error with it
I'm thinking it might be due to this line, since
color.ios
turned intocolor
for no real explanation, and the core-module still has an ios getter from what I've seenThe text was updated successfully, but these errors were encountered: