Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension buttons are sticking #60

Open
Naezr opened this issue Jun 23, 2024 · 6 comments
Open

Extension buttons are sticking #60

Naezr opened this issue Jun 23, 2024 · 6 comments
Labels
bug Something isn't working firefox bug Bug of Firefox, not of ShyFox help wanted Extra attention is needed

Comments

@Naezr
Copy link
Owner

Naezr commented Jun 23, 2024

Just leaving this here to let you know that this bug is known and researched

A prime example:
Toggle the checkbox number 3 in the Userchrome Toggle popup with the mouse. I rename it to "Hide Navbar", the default is just "Style 3". If you do this, the toggle will work, but with it the popup will disappear and the button will remain active as if the popup were open. To get rid of this you can restart your browser or turn off and on the extension

Similar behavior was also noticed with uBlock Origin. Only sometimes, when you click on the reload button inside a uBlock popup, the popup disappears and the button gets stuck.

This can be explained by the fact that popups from extensions are html children of #nav-bar - the panel with url bar. All other popups are children of #mainPopupSet - a separate node for popups.

And when #nav-bar is touched in some way, like toggle or something else, then the popups get squished. This is a bug in Firefox itself, not my theme. It's just that in vanilla all elements are static and have almost no animations. With the help of css #nav-bar except me nobody seems to have touched so deeply. That's why this bug came up only in such an unbelievable use case.

At the moment I don't have time to deal with Firefox developers, explaining to them the essence of this intricately woven bug that appears only when using some unknown css theme. Moreover, I don't know how to send bug reports to Firefox.

There's a small chance this can be fixed on the theme side, I'm not denying it. But I have no options at all on how to fix it, no clues at all.

I don't even know how to program properly myself, I'm just a schoolboy with a lot of free time. Yes, I am learning, but my level is obviously not enough. This theme is literally my first serious project, I learned while creating it.

If you are a Firefox developer or an enthusiast with enough knowledge and skill to figure out the Firefox source code, then just do it. Let's make our favorite open source browser even better!

@Naezr
Copy link
Owner Author

Naezr commented Jun 23, 2024

shy-stuck.webm

@Naezr Naezr added bug Something isn't working help wanted Extra attention is needed invalid This doesn't seem right labels Jun 23, 2024
@Naezr Naezr pinned this issue Jun 23, 2024
@maltejur
Copy link

maltejur commented Jul 5, 2024

I have investigated this a bit at https://bugzilla.mozilla.org/show_bug.cgi?id=1906433

@Naezr Naezr added firefox bug Bug of Firefox, not of ShyFox and removed invalid This doesn't seem right labels Jul 7, 2024
@Naezr
Copy link
Owner Author

Naezr commented Aug 2, 2024

I found a solution on the extension side. If the extension will close the popup when toggle is activated, the popup will not get stuck. It's rather inconvenient if you want to toggle multiple toggles at once, but it doesn't get stuck

2024-08-02.20-25-15.webm

@JoyHak
Copy link

JoyHak commented Aug 3, 2024

LOG

Firefox v127, Shy v3.6: still not fixed by the developers;
Firefox v128, Shy v3.8: still not fixed by the developers
gif
изображение

@Naezr
Copy link
Owner Author

Naezr commented Aug 12, 2024

This is most likely triggered by changing the width value of the navbar. I found this out through experimentation

@Halbour
Copy link

Halbour commented Aug 25, 2024

I have this problem too, with uBlock Origin being stuck.

@JoyHak
Copy link

JoyHak commented Aug 29, 2024

...я опять что-то сломал :D
Чиним: удаляем папку chrome - запускаем - закрываем - восстанавливаем.

wut.mp4

@fl4shback
Copy link

I noticed than when this happens, the Home and End keyboard keys stop working in the current window.

Do you have any idea for a workaround ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firefox bug Bug of Firefox, not of ShyFox help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants