Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error in calculating MAPE for QoR tasks #14

Open
Jedges opened this issue Aug 14, 2024 · 2 comments
Open

An error in calculating MAPE for QoR tasks #14

Jedges opened this issue Aug 14, 2024 · 2 comments

Comments

@Jedges
Copy link

Jedges commented Aug 14, 2024

/models/qor/SynthNetV1/utils.py line 258,When calling mean_absolute_percentage_error for calculation, are the two parameters placed in reverse order? The first one in the function description is y_true, and the second one is y_pred, but the code uses y_pre as the first parameter.
image
I am not sure if my understanding is wrong, please let me know if I am wrong

@animeshbchowdhury
Copy link
Contributor

Indeed, you pointed out an error. I did calculate the MAPE score incorrectly. It should have been reversed.

Can you make a PR with the change?

@Jedges
Copy link
Author

Jedges commented Aug 15, 2024

Yes, I maked a PR with the change. But I'm not sure if I'm doing the PR operation correctly, this is my first time using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants