Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5pt] Error on Fim Performance script #1326

Open
RobHanna-NOAA opened this issue Oct 22, 2024 · 1 comment · May be fixed by #1328
Open

[5pt] Error on Fim Performance script #1326

RobHanna-NOAA opened this issue Oct 22, 2024 · 1 comment · May be fixed by #1328
Assignees
Labels
bug Something isn't working FIM4 High Priority

Comments

@RobHanna-NOAA
Copy link
Contributor

RobHanna-NOAA commented Oct 22, 2024

During a test for test_case_by_hydro_id.py, it fails pretty much instantly and on all hucs with:

Found 269 test cases
Running 269 test cases:   0%|                                                                   | 0/269 [00:00<?, ?it/s]/usr/lib/python3/dist-packages/osgeo/gdal.py:315: FutureWarning: Neither gdal.UseExceptions() nor gdal.DontUseExceptions() has been explicitly called. In GDAL 4.0, exceptions will be enabled by default.
  warnings.warn(
AttributeError("'NoneType' object has no attribute 'GetLayer'")
AttributeError("'NoneType' object has no attribute 'GetLayer'")

AttributeError("'NoneType' object has no attribute 'GetLayer'")

Could this be a gdal issue? We updated some packages since this was last run for 4.5.2.11.

Note: This is high priority in order to continue with the current Prod run of hand_4_5_11_1.

@RobHanna-NOAA RobHanna-NOAA changed the title [5pt] Error on sierra test script [5pt] Error on Fim Performanceerra test script Oct 22, 2024
@RobHanna-NOAA RobHanna-NOAA changed the title [5pt] Error on Fim Performanceerra test script [5pt] Error on Fim Performance script Oct 22, 2024
@mluck mluck self-assigned this Oct 22, 2024
@mluck
Copy link
Contributor

mluck commented Oct 23, 2024

There is a missing a directory level for branch 0 here: https://github.com/NOAA-OWP/inundation-mapping/blob/dev/tools/test_case_by_hydro_id.py#L255 .

For example, this results in

catchment_gpkg 
 = /data/previous_fim/hand_4_5_11_1/12030109/branches/gw_catchments_reaches_filtered_addedAttributes_crosswalked_0.gpkg'

but should be

catchment_gpkg 
 = /data/previous_fim/hand_4_5_11_1/12030109/branches/0/gw_catchments_reaches_filtered_addedAttributes_crosswalked_0.gpkg'

@mluck mluck added the bug Something isn't working label Oct 23, 2024
@mluck mluck linked a pull request Oct 23, 2024 that will close this issue
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FIM4 High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants