Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagging all HydroVIS VPP resources #963

Open
EdisonOrellana-NOAA opened this issue Nov 14, 2024 · 7 comments
Open

tagging all HydroVIS VPP resources #963

EdisonOrellana-NOAA opened this issue Nov 14, 2024 · 7 comments
Assignees
Labels
Priority - High Priority Level Task 2 GAMA Task 2
Milestone

Comments

@EdisonOrellana-NOAA
Copy link
Contributor

HydroVIS AWS resources are not tagged in all the environments. Can you work on tagging all HydroVIS VPP resources? Make sure you follow the CCB process. Tagging requirements are documented here [1]. Fernando to share guidance on values for noaa:subcomponent tag.

[1] https://vlab.noaa.gov/redmine/projects/dis-24x7-cloud-support-services/wiki/Tag_Strategy#NWS-Dissemination-Mandatory-Tags

Team - I would suggest the following names for the subcomponent tag.

hydrovis-vpp-fim-dev
hydrovis-vpp-egis
hydrovis-vpp-ops-dash
hydrovis-vpp-other
hydrovis-nwps-web
hydrovis-nwps-api

https://vlab.noaa.gov/redmine/projects/owp-cloud-aws-hydrovis/repository

@EdisonOrellana-NOAA EdisonOrellana-NOAA added Priority - High Priority Level Task 2 GAMA Task 2 labels Nov 14, 2024
@EdisonOrellana-NOAA EdisonOrellana-NOAA added this to the V2.1.8 milestone Nov 14, 2024
@EdisonOrellana-NOAA EdisonOrellana-NOAA self-assigned this Nov 14, 2024
@RobHanna-NOAA
Copy link
Contributor

For all objects in AWS that have a custom tag called "owp_group" (values of fim-dev or ras2fim")...

  1. Either use caution on update all of our objects and keep me posted, so I can review / adjust them. OR
  2. Let me fix tags for our objects.

Note: we are only in nws-diss-hydrovis-dev

I am making a twin card for our tagging effort in the inundation-mapping repo issue 1343

@EdisonOrellana-NOAA
Copy link
Contributor Author

EdisonOrellana-NOAA commented Nov 25, 2024

  • Changes made to env yamls on vlab repo
  • tags added according to tag strategy
  • Tags are now a part of IaC and will show up after a redployment
  • Pushed to repo for review
  • Merged
  • Deployment for uat and ti scheduled for Nov 26
  • Deployment for prod will happen after ti/uat review or next prod deployment.

@EdisonOrellana-NOAA
Copy link
Contributor Author

EdisonOrellana-NOAA commented Dec 3, 2024

@RobHanna-NOAA
Copy link
Contributor

RobHanna-NOAA commented Dec 3, 2024

Do you think this will cover my Dev/TI 3 s3 buckets? either way, it is fine. We have a script prepared for our S3 buckets ready to go, but if yours covers it, that is fine too. Keep me posted.

@mluck : Something for you to also keep an eye on.

@EdisonOrellana-NOAA
Copy link
Contributor Author

EdisonOrellana-NOAA commented Dec 4, 2024

Hi @RobHanna-NOAA --- Check your s3 buckets, the buckets themselves should be well tagged but the S3 objects themselves inside the buckets should have no tags on them.

If your buckets are part of the IaC then it should cover those.

@EdisonOrellana-NOAA
Copy link
Contributor Author

  • Tagging complete for TI
  • IaC code is ready to go for deployment in UAT
  • Merge issues are holding up merging in UAT S3 object tags #1005 (looks like question of branching off prod vs ti are in conflict here)
  • Plan to discuss branch strategy and best path forward for implementing the tagging code in UAT when Shawn returns

@EdisonOrellana-NOAA
Copy link
Contributor Author

EdisonOrellana-NOAA commented Dec 18, 2024

Update: tagging changes for UAT will be implemented on the next regular deployment ~ week of Jan 6
After that is finished, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - High Priority Level Task 2 GAMA Task 2
Projects
None yet
Development

No branches or pull requests

2 participants