Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gtscript import under a central ndsl.gtscript #29

Open
FlorianDeconinck opened this issue Mar 15, 2024 · 0 comments
Open

Refactor gtscript import under a central ndsl.gtscript #29

FlorianDeconinck opened this issue Mar 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@FlorianDeconinck
Copy link
Collaborator

As shown in NOAA-GFDL/PyFV3#13 the current gtscript import are still pointing to the original gt4py package. This isn't an issue per se, but could induce further confusion for users.

We propose to wrap the common imports into a stub on ndsl e.g.:

from gt4py.cartesian.gtscript import PARALLEL, computation, horizontal, interval, region

would become

from ndsl.gtscript import PARALLEL, computation, horizontal, interval, region

We would not recommend moving them into ndsl so that the delimitation to gt4py is kept for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant