STY: Make units of pressure machine-readable #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DWesl - just checking to make sure you want this PR against main branch and not the dev/emc branch. |
So that's the name of the branch that would have allowed me to create a PR from the work in global-workflow with only the two new commits instead of fifty. |
6 tasks
|
Created #356 |
|
Since this one has been replaced, it should be closed... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #350 by using Pa instead of pa as units of pressure.
This should make the units of pressure generated by this repository machine-readable.
NOAA-EMC/fv3atm#859 makes other units machine-readable
How Has This Been Tested?
I made similar changes to a version of this repository in global-workflow, which I then compiled and ran. This produced netCDF history files with machine-readable units (specifically the python pint program, though I also checked with UDUnits).
Checklist:
Please check all whether they apply or not
global-workflow still generated grib2 output, which is presumably UPP's job.