From 50a52dc151f3b2da65790d7cadc3d6b40b76a1e6 Mon Sep 17 00:00:00 2001
From: "Henry R. Winterbottom"
 <49202169+HenryWinterbottom-NOAA@users.noreply.github.com>
Date: Tue, 18 Jun 2024 20:32:48 -0600
Subject: [PATCH] Removes misleading "No such file or directory" syntax errors
 from output files (#2688)

This PR addresses issue #1252. The following is accomplished:

- Prior to removing files, the existence of a file is checked prior to
attempting to remove; this is performed as noted
[here](https://github.com/NOAA-EMC/global-workflow/issues/1252#issue-1538627369);
this PR only addresses the the `chgrp` issue.

Refs #1252

---------

Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
---
 scripts/exglobal_diag.sh | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/scripts/exglobal_diag.sh b/scripts/exglobal_diag.sh
index 2d48053bd2..e1faa7b2ee 100755
--- a/scripts/exglobal_diag.sh
+++ b/scripts/exglobal_diag.sh
@@ -232,9 +232,11 @@ EOFdiag
    # Restrict diagnostic files containing rstprod data
    rlist="conv_gps conv_ps conv_pw conv_q conv_sst conv_t conv_uv saphir"
    for rtype in $rlist; do
-      set +e
-      ${CHGRP_CMD} *${rtype}*
-      ${STRICT_ON:-set -e}
+      for rfile in *"${rtype}"*; do 
+         if [[ -s "${rfile}" ]]; then
+            ${CHGRP_CMD} "${rfile}"
+         fi
+      done
    done
 
    # If requested, create diagnostic file tarballs