Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JCB hash #1229

Closed
RussTreadon-NOAA opened this issue Jul 22, 2024 · 1 comment · Fixed by #1230
Closed

Update JCB hash #1229

RussTreadon-NOAA opened this issue Jul 22, 2024 · 1 comment · Fixed by #1230
Assignees
@RussTreadon-NOAA

Comments

@RussTreadon-NOAA
Copy link
Contributor

As explained in jcb PR #10 and g-w PR #2782 the presence png files causes git-lfs failues on Hera. jcb PR #10 removed the png files from jcb develop at 8269ce4. g-w PR #2782 points at a hotfix snapshot of GDASApp. As g-w #2782 states, g-w should point at an authoritative snapshot of GDASApp.

This issue is opened to document the updating of the sorc/jcb hash in GDASApp.
@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Jul 22, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

Work for this issue will be done in feature/update_jcb

RussTreadon-NOAA added a commit that referenced this issue Jul 22, 2024
@RussTreadon-NOAA
update sorc/jcb hash to remove png files (#1229)
d87f24f
@RussTreadon-NOAA RussTreadon-NOAA mentioned this issue Jul 22, 2024
Merged
guillaumevernieres pushed a commit that referenced this issue Jul 22, 2024
@RussTreadon-NOAA
update sorc/jcb hash to remove png files (#1230)
e9252e1 
g-w PR [#2782](NOAA-EMC/global-workflow#2782)
and jcb PR [#10](NOAA-EMC/jcb#10) document the
need to remove png files from the `jcb` repository. The files were
removed at
[`8269ce4`](NOAA-EMC/jcb@8269ce4).

This PR updates the `sorc/jcb` hash to
[`8269ce4`](NOAA-EMC/jcb@8269ce4).

Resolves #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update sorc/jcb hash to remove png files NOAA-EMC/GDASApp
1 participant
@RussTreadon-NOAA