Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for newly added theories #2017

Open
scarlehoff opened this issue Mar 22, 2024 · 3 comments
Open

Add tests for newly added theories #2017

scarlehoff opened this issue Mar 22, 2024 · 3 comments
Assignees

Comments

@scarlehoff
Copy link
Member

scarlehoff commented Mar 22, 2024

While it is too late for the ones we already have, we should check (as much as possible) that the theories are correct going forward.

The idea would be that theories here, when they have the new naming format (4xxxxxxx) are checked. Some possible tests, please suggest others:

  • Check that the theory here is available in theories_slim with the same name and content*.
  • EW parameters are compatible

*unless we get around to make pineko use the theories from here, but that needs the set of defaults / mandatory / etc

@felixhekhorn
Copy link
Contributor

Question: we're talking about test within nnpdf, right? i.e. on FK tables?

then maybe some basic things first:

  • check the thing is loadable
  • check it yields a number when convoluted with NNPDF40_qed
  • check it has a theory metadata key
  • EW parameters are compatible

now, this is a much more basic problem: do you really want to check theory compatibility? this has a non-trivial tail ... because it would extend to everything and that means backwards compatibility ... e.g. PTO, kThr, FNS, masses, etc.

same goes for the eko side: do we want to check that settings are compatible?

@scarlehoff
Copy link
Member Author

Question: we're talking about test within nnpdf, right? i.e. on FK tables?

No! Yes, within NNPDF but only on the XXX.yaml file. Downloading the theories in the CI and testing is not feasible so for that we just need to hope people is doing something sane.

because it would extend to everything and that means backwards compatibility

I would only do it for new theories, just making sure that newly added theories don't have incompatible values.

@felixhekhorn
Copy link
Contributor

do you want to add some very basic tests? á là 0 < mc <= mb <= mt ? Also, once upon a time we had a number of checks in yadism https://github.com/NNPDF/yadism/pull/240/files#diff-45326adfe602c7e7b10bfde28ef61cc33e469eff9ca46e69b5788762db3cd8f4 (some inherited from Apfel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants