Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new commondata names in docs, examples and tests #1969

Open
6 of 8 tasks
Tracked by #1974
RoyStegeman opened this issue Mar 1, 2024 · 9 comments · Fixed by #2074
Open
6 of 8 tasks
Tracked by #1974

Update to new commondata names in docs, examples and tests #1969

RoyStegeman opened this issue Mar 1, 2024 · 9 comments · Fixed by #2074
Assignees

Comments

@RoyStegeman
Copy link
Member

RoyStegeman commented Mar 1, 2024

  • Remove reproduce 4.0
  • Update runcards in vp
  • Update runcards in n3fit
  • Update docstrings in n3fit
  • Update docstrings in vp
  • Update tests in vp
  • Update tests in n3fit
  • Update docs
@RoyStegeman RoyStegeman self-assigned this Mar 1, 2024
@RoyStegeman RoyStegeman changed the title Update the example runcards to use the new theories and commondata Update to new commondata names in docs and examples Apr 2, 2024
@RoyStegeman RoyStegeman changed the title Update to new commondata names in docs and examples Update to new commondata names in docs, examples and tests May 9, 2024
@enocera
Copy link
Contributor

enocera commented May 23, 2024

Dear @RoyStegeman, @peterkrack and I are willing to help change the names in this PR. I have a question regarding the docstrings in vp. Where do we exactly specify the dataset names?

@RoyStegeman
Copy link
Member Author

Thanks a lot! In the docstrings we regularly provide examples of how a function can be used (through the API). I put it separately because while the names in the tests can be updated and as long as the tests pass afterwords it's fine, the doctring examples may need to be tested. Feel free to do them simultaneously, but to me it made sense to separate them.

@RoyStegeman
Copy link
Member Author

Sorry this is not complete, if I just do a bruteforce search for the old names I still find plenty

@enocera
Copy link
Contributor

enocera commented Jul 31, 2024

Really? My bad, then. I thought I had fixed them all.

@RoyStegeman
Copy link
Member Author

No worries, it doesn't look like there are many left, but it's a bit early to close this

@enocera
Copy link
Contributor

enocera commented Jul 31, 2024

I'll have a second pass, then.

@RoyStegeman
Copy link
Member Author

Thanks, though if you don't have the time I'm sure we can include it in the list of tasks to be delegated in Morimondo

@scarlehoff
Copy link
Member

list of tasks to be delegated in Morimondo

Perhaps you meant the illustrious list of missions that will be assigned to honoured researchers in Morimondo.

@RoyStegeman
Copy link
Member Author

RoyStegeman commented Jul 31, 2024

Yes that's what I meant to type. Damn autocorrect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants