Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you open a session from a link, all following sessions have a broken result from the database connection #191

Open
doc-l opened this issue Jan 17, 2019 · 3 comments

Comments

@doc-l
Copy link

doc-l commented Jan 17, 2019

STR:

  1. Open session from link
  2. Open idarksurvey
  3. Click connect to database
  4. Only the session you had in the session link is visible (even when you visit from incognito)
@doc-l
Copy link
Author

doc-l commented Jan 17, 2019

Restarting spot-server fixes it, but if one person opens a session from a link, SPOT is broken for all people until the server is restarted...

@fdiblen
Copy link
Member

fdiblen commented Jan 17, 2019

In order to fix this issue, we need persistent storage for sessions. The sessions should either be stored in local storage of the browser or in the database.

Probably the most straight forward one is to use local storage.

@doc-l
Copy link
Author

doc-l commented Jan 21, 2019

Hi Faruk,

Not sure if I typed this correctly. It goes like this:

Person A shares link
Person B opens link
Person C cannot access database anymore (neither A nor B) until the server is restarted.

So that SPOT breaks for all users when one person opens a session is a feature?

It's a session, so I agree that localStorage (or maybe better sessionStorage) is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants