Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various refactor opportunities src/app.js #130

Open
jspaaks opened this issue Oct 19, 2017 · 0 comments
Open

various refactor opportunities src/app.js #130

jspaaks opened this issue Oct 19, 2017 · 0 comments

Comments

@jspaaks
Copy link

jspaaks commented Oct 19, 2017

Here's a couple of ideas for making the code easier to read.

  • CSVSeparator, CSVHeaders, CSVQuote, CSVComment are properties of app while they only get used lower in the hierarchy
  • fullscreenMode, mobileBrowser and demoSession are booleans therefore they should be named isFullscreen, isMobileBrowser and isDemoSession
  • local functions such as these should be at the top of the outer function because of function hoisting
  • the load/save session interactions as well as the functionality related to the welcome message could be loaded from their own modules.
  • (part of) widgetFactory and viewFactory should be moved to a place lower in the hierarchy. AFAICT they generate widgets in related to the Analyze view only, so that's where they need to be then.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant