Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bruke metaImage i topic hvor det ikke er Image som visualelement #2141

Merged

Conversation

MaPoKen
Copy link
Contributor

@MaPoKen MaPoKen commented Oct 7, 2024

@MaPoKen MaPoKen requested a review from a team October 7, 2024 08:00
@MaPoKen MaPoKen marked this pull request as ready for review October 7, 2024 08:00
@DeividasSvaikauskas
Copy link
Contributor

Vi burde kanskje avklare hva vi gjør med embedbyline/copyright før vi merger dette? Funker fint ellers

@gunnarvelle
Copy link
Member

Bør nok vise metabilde likt som visuelt element med lisensinformasjon ja.

@MaPoKen
Copy link
Contributor Author

MaPoKen commented Oct 7, 2024

Vi burde kanskje avklare hva vi gjør med embedbyline/copyright før vi merger dette? Funker fint ellers

Det blir kanskje vanskelig med copyright informasjonen når vi ikke har image-id'en for metaImage? 🤔

@gunnarvelle
Copy link
Member

Det blir kanskje vanskelig med copyright informasjonen når vi ikke har image-id'en for metaImage? 🤔

Må kanskje hente det då.

@gunnarvelle
Copy link
Member

Eller høre med Hedvig om kva vi skal gjøre

…age-instead-of-visualelements-other-than-image
@MaPoKen MaPoKen force-pushed the meta-image-instead-of-visualelements-other-than-image branch 2 times, most recently from 4f4466e to 4ae4928 Compare October 7, 2024 13:41
@MaPoKen
Copy link
Contributor Author

MaPoKen commented Oct 7, 2024

depends on NDLANO/graphql-api#496

@MaPoKen MaPoKen force-pushed the meta-image-instead-of-visualelements-other-than-image branch from 4ae4928 to b3680b8 Compare October 7, 2024 13:59
@gunnarvelle
Copy link
Member

I og med at du henter nytt skjema og #2123 ikkje er merga så må du oppdatere henting av meir data. Får melding om at url mangler på GQLMovie.

@gunnarvelle
Copy link
Member

Funker fint. Berre oppdater e2e-testene.

Copy link
Member

@gunnarvelle gunnarvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gunnarvelle gunnarvelle merged commit 8a6fbb7 into master Oct 8, 2024
6 checks passed
@gunnarvelle gunnarvelle deleted the meta-image-instead-of-visualelements-other-than-image branch October 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants