Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the controlled vocabulary for operations into PyActiveStorage #34

Open
bnlawrence opened this issue Oct 25, 2022 · 1 comment · May be fixed by #47
Open

Introduce the controlled vocabulary for operations into PyActiveStorage #34

bnlawrence opened this issue Oct 25, 2022 · 1 comment · May be fixed by #47
Assignees
Labels
excalibur Needs discussion by the excalibur team
Milestone

Comments

@bnlawrence
Copy link
Collaborator

Our current implementation passes a numpy reduction all the way down into the reduce_chunk method, which we expect to be implemented in storage. That argument needs to be a value from an enumeration (or an integer representing the index of the value in the list).

We need to pull the enumeration out into something visible to implementors, and push the enum value through the API, and reintroduce the numpy reduction in our python implementation of reduce_chunk.

We should also be clear about what we expect to be returned from each of these operations.

At the same time we should be clear about what our expectations are on the storage, we are starting to have several possible versions of active storage to consider:

  • vanilla (no missing data support, conforming to the minimal enum),
  • missing (with missing data support, conforming to whatever we decide in Multiple operations instead of means #33),
    • with or without the chained method support (if we think that is a good idea)
  • compressed (will need support for the simplest implementations of compression)
    • with or without
  • compressed and filtered (will need support for some of the simplest filters associated with some compression methods)

Perhaps we should have a way of interrogating active storage to find out which of these it has implemented?

@bnlawrence bnlawrence added the excalibur Needs discussion by the excalibur team label Oct 25, 2022
@bnlawrence
Copy link
Collaborator Author

(Needs tests for everything in the enumeration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excalibur Needs discussion by the excalibur team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants