-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor music box configuration file options #220
Comments
Actually, we might consider storing all of the mechanism information in this file as well. That would remove the need to write any files out. We would then have to update the musica API to take json objects, but that is already a goal we have anyways so that we push all of the parsing down to musica. @mattldawson would this be a good time to do that or do you think it's too soon? |
I like that idea. Do we need to make any changes to the |
@mattldawson I don't belive so. |
Doing just CSV vs. JSON in this ticket; leave choice of solver (Rosenbrock and others) to another issue. |
This is also related to #260, but only indirectly |
Initialization of concentrations involves a large number of floating-point numbers, and I believe that specification would be technically better in tabular form (CSV) instead of JSON. We have a JSON mechanism to include CSV file, rather than inserting many values into the JSON configuration. The CSV file would be better for our users to manage and review.
I know that we are retaining compatibility with the Fortran MusicBox. I recommend that we move forward soon with changes that will increase CSV usage through our product suite.
Originally posted by @carl-drews in #214 (review)
Acceptance criteria
Ideas
or, inplace conditions
--update-config
or--fix
so that when you givemusic_box -c my_config.json --fix
, we overwrite the old one, and maybe copy the origional to my_config.json.oldThe text was updated successfully, but these errors were encountered: