Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taylor Diagram class is not very robust #176

Closed
3 of 6 tasks
jukent opened this issue Nov 16, 2023 · 1 comment · Fixed by #219
Closed
3 of 6 tasks

Taylor Diagram class is not very robust #176

jukent opened this issue Nov 16, 2023 · 1 comment · Fixed by #219
Assignees
Labels
bug Something isn't working

Comments

@jukent
Copy link
Collaborator

jukent commented Nov 16, 2023

Things that have been giving me trouble when working on the Taylor Diagram example:

  • need taylor.add_xgrid(np.array([0.6, 0.9])) to enforce X-Y ratio. This shouldn't be necessary. User should have the right ratio without needing to specify diagonal lines from origin to correlation
  • dia.add_model_set(stddev=[0.6], corrcoef=[0.24]) says it accepts floats, but I need to put the values in a list for it to not raise an error.
  • Should add_xgrid() and add_ygrid()be renamed to add_corr_grid() and add_stddev_grid() since the x and y nature of this plot isn't that intuitive?
  • How to treat negative correlations? Add optional second quadrant to the left.
  • Changing figure size messes with legend locations - add note that best at 12,12
  • Add arrow annotation support to draw directional association between same variable of different models.
@jukent jukent added the bug Something isn't working label Nov 16, 2023
@jukent
Copy link
Collaborator Author

jukent commented Feb 22, 2024

Added a small note on the figure size to the doc string in #219.

Negative correlations in lowest priority.
Needing enforce X-Y ratio is higher priority, but not well understood
Renaming grids needs discussion on best path forward
Arrows is also low priority, but higher than the negative correlation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant