Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnsembleOfVariational.csh file cleanup needs adjusting #309

Open
jim-p-w opened this issue May 28, 2024 · 0 comments
Open

EnsembleOfVariational.csh file cleanup needs adjusting #309

jim-p-w opened this issue May 28, 2024 · 0 comments

Comments

@jim-p-w
Copy link
Collaborator

jim-p-w commented May 28, 2024

The file removal needs to be more restrictive: https://github.com/NCAR/MPAS-Workflow/blob/41d50adb25f84e95bdb7e2b2202ec1c84a01d352/bin/EnsembleOfVariational.csh#L129C10-L129C35

Each instance of this job will remove all of the output files. The job must only remove the output files for the ensemble members the script is executing, e.g.
if there are 12 ensemble members and EDASize is 3, then there will be 4 jobs (nDAInstances=4)

job 1 will handle members 1-3, job 2 will handle members 4-6, etc.

Also, the check for $MicrophysicsOuter should be protected by
if ( $?MicrophysicsOuter ) then to ensure the variable is set before dereferencing it.

if (${MicrophysicsOuter} == 'mp_thompson' ) then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant