MARBL: convert salt_flux to tracer flux and add to STF #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done for DIC, ALK, and related tracers. This mimics uptake and release of these tracers by sea ice.
|
@klindsay28 Is this PR ready to be reviewed and merged? |
|
Yes, it's ready for review. |
correct some indentation issues
mnlevy1981
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
@klindsay28 and I walked through these changes, and it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done for DIC, ALK, and related tracers.
This mimics uptake and release of these tracers by sea ice.
This changes answers for cases with MARBL, but not otherwise.