Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output relevant fields when diff or visc < 0 #252

Merged

Conversation

gustavo-marques
Copy link
Collaborator

@gustavo-marques gustavo-marques commented Jul 19, 2023

Writes useful fields when the diffusivity of viscosity is less than zero. These should help understand the root cause of such cases and facilitate the necessary adjustments.

Writes useful fields when the diffusivity of viscosity is less than zero.
The should help understanding the root cause of such cases and facilitate
the necessary adjustments.
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (aa58724) 37.07% compared to head (5709f05) 37.06%.

❗ Current head 5709f05 differs from pull request most recent head b4bd223. Consider uploading reports for the commit b4bd223 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           dev/ncar     #252      +/-   ##
============================================
- Coverage     37.07%   37.06%   -0.01%     
============================================
  Files           264      264              
  Lines         74421    74436      +15     
  Branches      13780    13781       +1     
============================================
  Hits          27592    27592              
- Misses        41739    41754      +15     
  Partials       5090     5090              
Impacted Files Coverage Δ
src/parameterizations/vertical/MOM_CVMix_KPP.F90 0.75% <0.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alperaltuntas alperaltuntas merged commit 47f737f into NCAR:dev/ncar Jul 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants