Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REMAP_VEL_CONSERVE_KE breaks dimensional consistency tests #300

Open
gustavo-marques opened this issue Sep 4, 2024 · 3 comments
Open

REMAP_VEL_CONSERVE_KE breaks dimensional consistency tests #300

gustavo-marques opened this issue Sep 4, 2024 · 3 comments

Comments

@gustavo-marques
Copy link
Collaborator

@alperaltuntas found that the dimensional consistency tests break when REMAP_VEL_CONSERVE_KE = True.
CC'ing @iangrooms

@iangrooms
Copy link

OK, I will take a look.

@iangrooms
Copy link

iangrooms commented Sep 21, 2024

I can't get dev/ncar to pass dimensional consistency even with REMAP_VEL_CONSERVE_KE = False, so I can't make progress on this for now.

@iangrooms
Copy link

I think the lines that break the dimensional consistency tests are here and here. The correction is based on the square root of the ratio of two kinetic energies, and to avoid division by 0 I introduced a dimensional constant 1.E-19. This literal constant doesn't scale in the dimensional consistency tests, which causes the results to change and the test to fail. I changed the code to remove the literal constant here and here.

Separately, on the same branch I also changed the computation of the diagnostics ale_u2 and ale_v2 to make the code clearer. I don't think this change is necessary to fix the dimensional consistency tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants