You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the lines that break the dimensional consistency tests are here and here. The correction is based on the square root of the ratio of two kinetic energies, and to avoid division by 0 I introduced a dimensional constant 1.E-19. This literal constant doesn't scale in the dimensional consistency tests, which causes the results to change and the test to fail. I changed the code to remove the literal constant here and here.
Separately, on the same branch I also changed the computation of the diagnostics ale_u2 and ale_v2 to make the code clearer. I don't think this change is necessary to fix the dimensional consistency tests.
@alperaltuntas found that the dimensional consistency tests break when
REMAP_VEL_CONSERVE_KE = True
.CC'ing @iangrooms
The text was updated successfully, but these errors were encountered: