Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] error in sanity checks for background mixnig #237

Open
dcherian opened this issue Mar 16, 2023 · 0 comments
Open

[minor] error in sanity checks for background mixnig #237

dcherian opened this issue Mar 16, 2023 · 0 comments

Comments

@dcherian
Copy link

dcherian commented Mar 16, 2023 •
edited
Loading

Minor comment but I'm pretty sure this check is wrong and unnecessary when horiz_background_mixing is activated.

MOM6/src/parameterizations/vertical/MOM_bkgnd_mixing.F90

Lines 249 to 257 in 9786710

if (CS%Bryan_Lewis_diffusivity .or. CS%horiz_varying_background) then
prandtl_bkgnd_comp = CS%prandtl_bkgnd
if (CS%Kd /= 0.0) prandtl_bkgnd_comp = Kv / CS%Kd
if ( abs(CS%prandtl_bkgnd - prandtl_bkgnd_comp)>1.e-14) then
call MOM_error(FATAL, "bkgnd_mixing_init: The provided KD, KV and PRANDTL_BKGND values "//&
"are incompatible. The following must hold: KD*PRANDTL_BKGND==KV")
endif
endif

Kv and CS%Kd aren't used at all and prandtl_bkgnd is always used to get Kvfrom Kd
alperaltuntas pushed a commit that referenced this issue Aug 9, 2024
@Hallberg-NOAA @marshallward
+FIX_USTAR_GUSTLESS_BUG is now USTAR_GUSTLESS_BUG
5c14668 
  Renamed the runtime parameter FIX_USTAR_GUSTLESS_BUG to USTAR_GUSTLESS_BUG
(with a switch between the meanings of true and false for the two parameters)
for consistency with the syntax of other bug-fix flags in MOM6 and to partially
address dev/gfdl MOM6 issue #237.  Input parameter files need not be changed
right away because MOM6 will still work if FIX_USTAR_GUSTLESS_BUG is specified
instead of USTAR_GUSTLESS_BUG, but USTAR_GUSTLESS_BUG will be logged, so there
are changes to the MOM_parameter_doc files.   By default or with existing input
parameter files, all answers are bitwise identical, and there is error handling
if inconsistent settings of FIX_USTAR_GUSTLESS_BUG and USTAR_GUSTLESS_BUG are
both specified.
alperaltuntas pushed a commit that referenced this issue Aug 9, 2024
@Hallberg-NOAA @marshallward
+FIX_UNSPLIT_DT_VISC_BUG is now UNSPLIT_DT_VISC_BUG
eac3bb3 
  Renamed the runtime parameter FIX_UNSPLIT_DT_VISC_BUG to UNSPLIT_DT_VISC_BUG
(with a switch between the meanings of true and false for the two parameters)
for consistency with the syntax of other bug-fix flags in MOM6 and to partially
address dev/gfdl MOM6 issue #237.  Input parameter files need not be changed
right away because MOM6 will still work if FIX_UNSPLIT_DT_VISC_BUG is specified
instead of UNSPLIT_DT_VISC_BUG, but UNSPLIT_DT_VISC_BUG will be logged, so there
are changes to the MOM_parameter_doc files.   By default or with existing input
parameter files, all answers are bitwise identical, and there is error handling
if inconsistent settings of FIX_UNSPLIT_DT_VISC_BUG and UNSPLIT_DT_VISC_BUG are
both specified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcherian