Add MCOG support #198
Comments
alperaltuntas
pushed a commit
that referenced
this issue
Jul 7, 2023
* Setup OBC segments for COBALT/OBGC tracers
- These are updates required to setup OBC segments for OBGC tracers.
- Since COBALT package has more than 50 tracers using the MOM6 table
mechanism for setting up OBC segments is not feasible. Rather, this
update delegates such setup to mechanims used in ocean_BGS tracers
leaving MOM6 mechanism for native tracers intact.
- Fixed issues caught by MOM6 githubCI
* Add capability to change obc segment update period
- COBALT tracers do not need as frequent segment bc updates and can
use a larger update period to speed up the model.
This commit introduces a new parameter DT_OBC_SEG_UPDATE_OBGC
that can be adjusted for obc segment update period.
- This commit applies the change only to BGC tracers but can easily
be changed to apply for all.
* Insert missing US%T_to_sec
- The unit conversion factor was missing causing a crash in a newer test.
* Updates from Andrew Ross
- Avoid low initial values in the tracer reservoirs
* Per Andrew Ross review
* corrected indentation per review
* Avoid using module vars per review request
- Reviewer asked to avoid using module variables with "save" attributes.
- This commit hides the module variables inside the existing OBC type.
* Coding style corrections per review
* Modification per review: do_not_log if .not.associated(CS%OBC)
Co-authored-by: Robert Hallberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The POP module mcog.F90 lets us bin photosynthetically active radiation in a single column based on ice thickness above it. It's not a BGC-specific parameterization, but as far as I know MARBL is the only tracer package in POP that makes use of this binning... so I'll port it to MOM in a separate PR and then merge it into my MARBL driver branch for further testing.
The text was updated successfully, but these errors were encountered: