Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LinkProperties from StoriesHub Component #1325

Open
sandrahoang686 opened this issue Dec 16, 2024 · 0 comments
Open

Remove LinkProperties from StoriesHub Component #1325

sandrahoang686 opened this issue Dec 16, 2024 · 0 comments
Assignees
Labels
tech debt veda v2 VEDA Refactor Epic Work

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Dec 16, 2024

This is a follow-up ticket from #1108 (comment).
And a follow-up from this PR #1310.

We need to remove routing/nav dependencies from StoriesHub Component. Remove LinkProperties prop dependency with a callback to handle navigation instead.

@sandrahoang686 sandrahoang686 added tech debt veda v2 VEDA Refactor Epic Work labels Dec 16, 2024
sandrahoang686 added a commit that referenced this issue Dec 17, 2024
**Related Ticket:** #1108
**Related PR:** developmentseed/next-veda-ui#25

 **v5.11.3-alpha.0** published from this branch

### Description of Changes
As part of the greater holistic approach - I think its best to move away
from having our library components tightly integrated w/ routing. This
is the first iteration to remove **linkProperties**. This PR only
worries about removing **linkProps** the **DataCatalog Component**.
DataCatalog view no longer has to pass in linkProperties or have to
directly worry about routing, we can just pass in a callback now that
decides what to do during some action.

This is an iterative approach, i've created tickets to remove routing
from the other core components. But we can't remove routing directly
from the Card component itself easily as GHG uses the card component
directly
[here](https://github.com/US-GHG-Center/veda-config-ghg/blob/dfe611f27f910bc6428a2b13fe50678710511e68/custom-pages/news-and-events/component.tsx#L5).
So that should be its own separate ticket BUT... we are to be redoing
the card component for the new instances - where its probably best to
rewrite it. As currently its not in an ideal place to scale... so i'll
create a placeholder ticket for card component for now but we can
probably tackle removing routing when rewriting the card component.

cc @vgeorge @hanbyul-here @dzole0311 

Follow-up tickets created: 
* #1325
* #1326
* #1327

### Notes & Questions About Changes
_{Add additonal notes and outstanding questions here related to changes
in this pull request}_

### Validation / Testing
- [ ] Validate DataCatalog cards are linking correctly
- [ ] Validate selecting cards in DatasetSelectorModal is working as it
should
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt veda v2 VEDA Refactor Epic Work
Projects
None yet
Development

No branches or pull requests

2 participants