From 60db648e23c28d9e22798b616747adac09fb49c2 Mon Sep 17 00:00:00 2001
From: NISH1001 <nishanpantha@gmail.com>
Date: Tue, 27 Feb 2024 14:31:57 -0600
Subject: [PATCH] Remove operator and value in payload if they are None in
 AdvancedParams

Sample:

```python
{
    'app': 'vanilla-search',
    'query': {
        'name': 'query',
        'text': 'himawari',
        'isFirstpage': False,
        'strictRefine': False,
        'removeDuplicates': False,
        'action': 'search',
        'page': 1,
        'pageSize': 10,
        'advanced': {
            'collection': '/user_needs_database/snwg-assessments-2020/',
            # 'value': None, 'operator': None,
        }
    }
}
```
---
 pynequa/api/api.py | 41 +++++++++++++++++++++--------------------
 pynequa/models.py  | 13 ++++++++-----
 2 files changed, 29 insertions(+), 25 deletions(-)

diff --git a/pynequa/api/api.py b/pynequa/api/api.py
index 30d0bf0..da5a115 100644
--- a/pynequa/api/api.py
+++ b/pynequa/api/api.py
@@ -5,13 +5,13 @@
 
 
 class API:
-    '''
-        API Class handles all HTTP Requests
+    """
+    API Class handles all HTTP Requests
 
-        Attributes:
-            base_url(string): REST API base URL for Sinequa instance
-            access_token(string): token for Sinequa authentication
-    '''
+    Attributes:
+        base_url(string): REST API base URL for Sinequa instance
+        access_token(string): token for Sinequa authentication
+    """
 
     def __init__(self, access_token: str, base_url: str) -> None:
         if not access_token or not base_url:
@@ -21,9 +21,7 @@ def __init__(self, access_token: str, base_url: str) -> None:
         self.base_url = base_url
 
     def _get_headers(self) -> Dict:
-        headers = {
-            "Authorization": f"Bearer {self.access_token}"
-        }
+        headers = {"Authorization": f"Bearer {self.access_token}"}
         return headers
 
     def _get_url(self, endpoint) -> str:
@@ -31,19 +29,22 @@ def _get_url(self, endpoint) -> str:
 
     def get(self, endpoint) -> Dict:
         """
-            This method handles GET method.
+        This method handles GET method.
         """
-        session = requests.Session()
-        resp = session.get(self._get_url(endpoint=endpoint),
-                           headers=self._get_headers())
-        session.close
-        return resp.json()
+        with requests.Session() as session:
+            resp = session.get(
+                self._get_url(endpoint=endpoint), headers=self._get_headers()
+            )
+            return resp.json()
 
     def post(self, endpoint, payload) -> Dict:
         """
-            This method handles POST method.
+        This method handles POST method.
         """
-        session = requests.Session()
-        resp = session.post(self._get_url(endpoint=endpoint),
-                            headers=self._get_headers(), json=payload)
-        return resp.json()
+        with requests.Session() as session:
+            resp = session.post(
+                self._get_url(endpoint=endpoint),
+                headers=self._get_headers(),
+                json=payload,
+            )
+            return resp.json()
diff --git a/pynequa/models.py b/pynequa/models.py
index 553cf13..36e0865 100644
--- a/pynequa/models.py
+++ b/pynequa/models.py
@@ -31,6 +31,7 @@ class TreeParams(AbstractParams):
             Possible values: '=', '!=', '<', '<=', '>=', '>', 'between', 'not between'.
         value (str): The filter value (required).
     """
+
     box: str = ""
     column: str = ""
     op: str = ""
@@ -85,7 +86,7 @@ def generate_payload(self, **kwargs) -> Dict:
 class AdvancedParams(AbstractParams):
     col_name: str = ""
     col_value: str = None
-    value:  str or int = None
+    value: str or int = None
     operator: str = None
     debug: bool = False
 
@@ -96,10 +97,13 @@ def generate_payload(self, **kwargs) -> Dict:
         """
         payload = {
             self.col_name: self.col_value,
-            "value": self.value,
-            "operator": self.operator
         }
 
+        if self.value:
+            payload["value"] = self.value
+        if self.operator:
+            payload["operator"] = self.operator
+
         if self.debug:
             logger.debug(payload)
 
@@ -111,8 +115,7 @@ class QueryParams(AbstractParams):
     name: str = ""  # required
     action: Optional[str] = None
     search_text: str = ""  # required
-    select_params: Optional[List[SelectParams]
-                            ] = field(default_factory=lambda: [])
+    select_params: Optional[List[SelectParams]] = field(default_factory=lambda: [])
     additional_select_clause: Optional[str] = None
     additional_where_clause: Optional[str] = None
     open_params: Optional[List[OpenParams]] = field(default_factory=lambda: [])