Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] [Kiosk] Enable Listing for Sale Using Any Coin #17894

Open
cybercent opened this issue May 23, 2024 · 4 comments
Open

[Feature Request] [Kiosk] Enable Listing for Sale Using Any Coin #17894

cybercent opened this issue May 23, 2024 · 4 comments
Assignees

Comments

@cybercent
Copy link

cybercent commented May 23, 2024

Feature Request: Enable Listing for Sale Using Any Coin<T>

At present, the Kiosk module uses Coin<SUI>. I propose adding new functions to the package that would:

  • Allow users to list items for sale using any coin.
  • Enable users to purchase items using any coin.
@damirka
Copy link
Contributor

damirka commented Jun 28, 2024

Hey @cybercent, can you elaborate on the use case that you're trying to solve? And how would you see creator's policy with this change in place? How would the creator royalty be calculated in the case where I list my NFTs for FUD or any other coin?

@cybercent
Copy link
Author

Hey @damirka, thanks for reviewing this.

The proposal is to add new functions that use generics for the coin type, allowing users to list NFTs for sale in coins other than SUI.

Due to SUI's price volatility, users must frequently list and delist their NFTs or set a high "safe" price, which reduces market liquidity.

By enabling users to list in stable coins like USDC, we can offer a more stable alternative.

This change also introduces new possibilities. For example, a PTB transaction could be created to allow a buyer with SUI to purchase an NFT listed in USDC. The PTB would first convert SUI to USDC using Turbos or Aftermath, and then complete the NFT purchase.

Ideally, the transfer policy should remain unchanged. The fee would be paid in the coin type used for the purchase, as set by the seller.

@damirka
Copy link
Contributor

damirka commented Jun 28, 2024

I see what you're saying here. And my suggestion would be to try and implement this as a Kiosk Extension. The seller sets the price in stable coin, but the deal happens in SUI. I would love to see this one implemented, actually. Never got a chance to do myself

@damirka
Copy link
Contributor

damirka commented Jun 28, 2024

The tricky part would be tracking the price of the sale and delivering, as you suggest, USDC to the seller (while maintaining the amount in the TransferRequest), but we can see how it plays out, and what we can do if there's a reference implementation. That is, if you want to try and do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants