Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestConnectionPriority still useful? #28

Open
Mygod opened this issue Aug 14, 2023 · 6 comments
Open

requestConnectionPriority still useful? #28

Mygod opened this issue Aug 14, 2023 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@Mygod
Copy link
Owner

Mygod commented Aug 14, 2023

Anything I can find about this is at least 5 years ago: https://www.reddit.com/r/TheSilphRoad/comments/6vt55n/android_improve_goplus_blutooth_responsiveness/

From personal testing I cannot tell any different with this on vs off.

@Mygod Mygod added the help wanted Extra attention is needed label Aug 14, 2023
@RecentRunner
Copy link

Are we currently using this in the app?

@Mygod
Copy link
Owner Author

Mygod commented Oct 26, 2023

No.

@RecentRunner
Copy link

Okay so from what I can tell it totally depends on which device your using. So it definitely made a BIG difference on my LG Velvet and Oneplus 7t (Running LineageOS). No different on my Samsung S23 ultra tho

So I'm just going to conjecture that whether this works or not depends on the phone's vendor and firmware?

@Mygod
Copy link
Owner Author

Mygod commented Nov 26, 2023

Care to elaborate on the "BIG difference"?

@perryyan
Copy link

Hi,
I have done some input:

Currently I have a Samsung Z fold 4 and I use a megacom dual catchmon from a few years ago.

I found that manually setting the Connection Priority to high using nRF connect dramatically increased the responsiveness of the dual catchmon!

Without it, sometimes stops would fail to spin and pokemon would not be caught even after waiting 10+ seconds. I found this to be similar on a OnePlus 5T and Pixel 5 as well.

I would love to see a setting that automatically sets Connection Priority to high on connect.

Thanks!

@Mygod
Copy link
Owner Author

Mygod commented Nov 26, 2023

Thanks but I would not consider this conclusive evidence that connection priority is useful. If it only occurs "sometimes", it could as well be caused by connection jittering or other stuff. In other words, it cannot be reliably reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants