Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half of the comments are russian. #90

Open
akaltar opened this issue Aug 10, 2015 · 5 comments
Open

Half of the comments are russian. #90

akaltar opened this issue Aug 10, 2015 · 5 comments

Comments

@akaltar
Copy link

akaltar commented Aug 10, 2015

This makes it incredibly hard to understand the code and/or contribute. I would recommend to translate all russian comments to english, perhaps with some automated translate tool. This would make the project much more accessible and understandable for newcomers, especially as it lacks a proper documentation such as how to build and quick start examples.

@akaltar
Copy link
Author

akaltar commented Aug 15, 2015

I would even do this, just want to know if the community would welcome it.

@ghost
Copy link

ghost commented Oct 13, 2015

I'm all for translating comments, but using an automated translation tool some of the original meaning would surely get lost.

@Altren
Copy link
Contributor

Altren commented Oct 13, 2015

Using automated tool is definitely pointless, unless you'll check every comment after that and remove/revert useless. Having bad comment might be worse than not having any.

@acmepjz
Copy link
Contributor

acmepjz commented Aug 29, 2016

By the way, not only plenty of the comments are Russian, but also a lot of files are using Windows-1251 encoding instead of UTF-8. This makes some '\n' in source files get parsed incorrectly under Windows (I'm using GBK as default text encoding and this makes that sometimes some Russian character'\n' be recognized as a Chinese character, thus eating '\n' and the following line of code), which results in compile error and weird bugs. (At first the 3 out of 4 tools crash at startup, and I take a long time to find where the bug is.)

Perhaps you should convert all the source files to be UTF-8 encoded?

FYI: I use this script to convert them (I'm under Windows)

@echo off
set PATH=C:\Program Files (x86)\Git\bin;%PATH%
for /F "delims=" %%f in ('dir/a-d/b/s *.cpp *.h *.txt') do (
    iconv.exe -s -f UTF-8 -t UTF-8 "%%f" > NUL
    if ERRORLEVEL 1 (
        iconv.exe -s -f CP1251 -t UTF-8 "%%f" > "%%f.tmp"
        if ERRORLEVEL 1 (
            echo Error: %%f is neither UTF-8 nor CP1251!
        ) else (
            copy /y "%%f.tmp" "%%f"
            echo %%f is converted from CP1251 to UTF-8
        )
        del "%%f.tmp"
    )
)
@echo on

@acmepjz
Copy link
Contributor

acmepjz commented Oct 3, 2017

Hi, please look at a patch #132 which converts Windows-1251 encoding files to UTF-8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants