Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split training and features from application #32

Open
hagenw opened this issue Jul 7, 2021 · 2 comments
Open

Split training and features from application #32

hagenw opened this issue Jul 7, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@hagenw
Copy link

hagenw commented Jul 7, 2021

As correctly stated in the documentation, feature extraction and training is not needed if you just want to run the model.
So it might be worth in the long run to split this package as it installs way too many dependencies for just using the model. This makes it also very likely that a user will get some conflicts if she tries to install it together with other models.
One solution for the application would be to use a more generic framework like ONNX, which would remove all the tensorflow related dependencies.

For all the others I haven't checked yet, which are only needed for feature extraction and training, but I hope there will be a few more packages.

This is nothing you have to do for the JOSS review, but just a hint for future versions.

@BreezeWhite
Copy link
Member

Hi, thanks for the suggestion. I'll do some survey on how to do it.

@keunwoochoi
Copy link

(Commenting to link this to openjournals/joss-reviews#3391)

@yoyolicoris yoyolicoris added the enhancement New feature or request label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants