Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feature request ] Logo changing/customizing in the address bar #184

Open
7system7 opened this issue Oct 4, 2023 · 2 comments
Open

[ Feature request ] Logo changing/customizing in the address bar #184

7system7 opened this issue Oct 4, 2023 · 2 comments

Comments

@7system7
Copy link

7system7 commented Oct 4, 2023

Firstly, thank you for this awesome extension. It still should be part of the Firefox.

Just a suggestion to change the logo to something similar than this. Maybe can said that this is the collectively agreed logo for sharing. (at least on the mobile platform 😁)

image

And/or another idea to have a chance to change this logo. I personally, use a theme for firefox, so, I do not know how it seems on the default theme, but here it almost blends into the background. (If the OS uses light theme.)

image

on dark theme

image

I know that, the plugin uses its own logo but it can be acceptable to use another logo in use than the logo is in the plugin list. 😊

@Mte90
Copy link
Owner

Mte90 commented Oct 5, 2023

Thanks for your ticket, we use the original logo of the Firefox Share feature of Firefox 57 (the extension takes the name from that).
About the logo color based on the theme we use the dark/light color detection to use a different icon and in my tests change rightly between light/dark, did you tried with a different theme?

@7system7
Copy link
Author

7system7 commented Oct 5, 2023

Oh, I did not remembered that, this is the original logo. I did not tested that, because I won't change the theme for only one extension, even if it works there. (And actually I am sure, it is working w/ the default theme otherwise someone else would have noticed it before.)

I can understand if you do not have time for this, it was only a suggestion, maybe others have also encountered the problem w/ theming. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants