added html args #52
added html args #52
Conversation
|
|
||
| if ARGS.html is not None: | ||
| with open("report.html", "w") as e: | ||
| for lines in report_file.readlines(): |
There was a problem hiding this comment.
Not working since your reading a file that is not closed yet (tested on python 3.10, may work elsewhere)
You'll have to close the report_file before, then reopen it in read mode and use report_file.read() simply
|
@FireNdIce3 first warm thanks for your contribution ! I made a quick review, you're not far from reaching a solution. message me if you need help. |
|
I think also that there should be the repo anchor link in the HTML report not just a pre list of the various repositories. |
|
Fixed the conflicts but @FireNdIce3 are you still interested on finish the PR? |
|
Yes, I am.. can you please give me a few days to fix the issue? |
|
yes no problem, I saw that you disappeared so I wasn't sure :-) |
|
Ping as the hacktoberfest is finishing and if we need to tests to approve it we need that the PR is completed. |
|
any updates? |
|
I'm trying to get some time on it this Friday, since it doesn't seem to require much time. Sorry for the delay, work sucked all my time since mid-october. |
I saw the code and did what I felt was right. If I am wrong somewhere, please guide me so I can solve this issue.
Thanks,
Fix #51