Draft: Feats UI/1.18 #212

Uhutown · 2023-08-15T16:37:57Z

No description provided.

-fixed missing bottom texture added

into feats_UI/1.18

ich gebs auf

This reverts commit adb712b.

This reverts commit 03b351d.

This reverts commit 936270c.

MrTroble · 2023-09-20T14:27:22Z

src/main/java/com/troblecodings/signals/guis/ContainerPlacementtool.java

getInfo should be cached and

It's getting chached in the SuperClass ContainerBase. Why should we chache it two times?

No the function call it self is not it is still entering into a function call every time. Means function call overhead in EVERY line

If you need to change things it makes it harder. What if you make the function more complex? Even only by accident?

MrTroble · 2023-09-20T14:28:03Z

src/main/java/com/troblecodings/signals/guis/ContainerSignalBox.java

getInfo local cache

The same as abow

MrTroble · 2023-09-20T14:28:40Z

src/main/java/com/troblecodings/signals/guis/ContainerSignalController.java

getinfo local cache

MrTroble · 2023-09-20T14:30:11Z

src/main/java/com/troblecodings/signals/guis/GuiSignalBox.java

-    private static final float[] ALL_LINES = getLines();
-    private static final int TILE_WIDTH = 10;
-    private static final int TILE_COUNT = 100;
+    public static final float[] ALL_LINES = getLines();


Why is this line cache public now? Access should be limited as the contents might be invalidated

MrTroble · 2023-09-20T14:32:55Z

src/main/java/com/troblecodings/signals/guis/GuiSignalBox.java

@@ -122,9 +129,10 @@ public void update(final String errorString) {
    }

    private void resetTileSelection() {
-        this.entity.findRecursive(UIColor.class).stream()
-                .filter(color -> color.getColor() == SELECTION_COLOR)
+        this.entity.findRecursive(UIColor.class).stream().filter(


Yeah so this should be done differently if we are honest

Cache the UIColors for example idk thing of something

MrTroble · 2023-09-20T14:35:11Z

src/main/java/com/troblecodings/signals/guis/NamableContainer.java

getInfo should be localy cached

MrTroble · 2023-09-20T14:36:26Z

src/main/java/com/troblecodings/signals/handler/ClientNameHandler.java

@@ -21,7 +21,7 @@ public class ClientNameHandler implements INetworkSync {

    public static String getClientName(final NameStateInfo info) {
        synchronized (CLIENT_NAMES) {
-            return CLIENT_NAMES.getOrDefault(info, "");
+            return new String(CLIENT_NAMES.getOrDefault(info, ""));


Why is there a string copy? Strings are immutable

Ok I wasn't if this is so

MrTroble · 2023-09-20T14:37:50Z

src/main/java/com/troblecodings/signals/handler/ClientSignalStateHandler.java

@@ -27,7 +27,7 @@ public class ClientSignalStateHandler implements INetworkSync {

    public static final Map<SEProperty, String> getClientStates(final ClientSignalStateInfo info) {
        synchronized (CURRENTLY_LOADED_STATES) {
-            return CURRENTLY_LOADED_STATES.computeIfAbsent(info, _u -> new HashMap<>());
+            return CURRENTLY_LOADED_STATES.getOrDefault(info, new HashMap<>());


Why was this changed unneccessary hash map allocation on all accesses

MrTroble · 2023-09-20T17:25:32Z

src/main/java/com/troblecodings/signals/signalbox/SignalBoxPathway.java

@@ -335,6 +340,41 @@ public Optional<Point> tryReset(final BlockPos position) {
        return Optional.of(point);
    }

+    private boolean checkReverseReset(final BlockPos pos) {


What is this trying to achieve?

This is for the revers pathway reset.

Yeah I can read but what is this doing and why are we in linear time here what exactly do you mean by reverse reset

Skywalkervalle and others added 30 commits July 9, 2023 20:57

Update circle.json

aabe442

-fixed missing bottom texture added

feat: added Help page

dfbaf89

lang keys

63279af

feat: added manipulator item

43ca914

feat: update signal panel

fc64600

Merge branch 'feats_UI/1.18' of https://github.com/MrTroble/Open-Signals

feb3a1c

into feats_UI/1.18

ref: info color & platform edge symbol

48623ec

feat: added description for signalbox info panel

0623fd3

ref: "info"

4aa3228

feat: help page info

ae8b76e

feat: added system for reverse reset

dcf06d6

feat: added tooltip to customname

cded6b4

fix: tooltip out of screen

23bf5e5

feat: added tooltip hiding option

10614b4

ref: better code performance and appreance

90184bd

fix: HelpUsageMode doesn't beem shown at UI opening

a90a0ea

fix: Revers Reset from other side

42800c7

ref: autopathway desc

be5355c

fix: reverse reset on corners

bab04c1

Merge branch 'feats_UI/1.18' of https://github.com/MrTroble/Open-Signals

7d4761a

into feats_UI/1.18

fix: fixed desc String of nopathfound

71c1b55

feat: added currently selected start to HelpPage

12d98b4

ref: removed next point from help page

8fa6844

feat: added enabled subsidiaries to HelpPage

39825a5

feat: removed lines in UsageMode

1e86580

feat: added button to disable Subsidiary

03ac72e

changed sown name for Subsidiary

d5a0001

feat: added shortcuts

cc0c8a8

feat: added desc and lang keys

3276e2c

ref: change edit color

e5954f1

Jeronimo97 added 21 commits August 30, 2023 18:41

Update versioncheck.yml

351479f

Update versioncheck.yml

bd27b8b

Update versioncheck.yml

a323d90

ich gebs auf

test versioning check

4afd47a

Update versioncheck.yml

b93f60a

Update versioncheck.yml

dad12bd

Update versioncheck.yml

f82e314

Update versioncheck.yml

be74771

Update versioncheck.yml

fb5cfa6

Update versioncheck.yml

8433e0b

Update versioncheck.yml

77804b9

Update versioncheck.yml

a50e99b

Update versioncheck.yml

9f2db57

chore: revert version

045aadb

test version check

936270c

Update versioncheck.yml

03b351d

Update versioncheck.yml

adb712b

Revert "Update versioncheck.yml"

378c8ee

This reverts commit adb712b.

Revert "Update versioncheck.yml"

d1f58b7

This reverts commit 03b351d.

Revert "test version check"

ee1a4be

This reverts commit 936270c.

feat: super secret switch handle update

ae864b5

Jeronimo97 approved these changes Aug 31, 2023

View reviewed changes

Uhutown and others added 3 commits September 1, 2023 13:51

ref: better code performance

a8021ce

fix: Issue with RS Output at signal

69b3e04

ref: reduced NBT Usage

2aa4266

MrTroble requested changes Sep 20, 2023

View reviewed changes

MrTroble self-requested a review September 24, 2023 18:41

MrTroble approved these changes Sep 24, 2023

View reviewed changes

Uhutown merged commit 41a638c into 1.18-master Sep 24, 2023
5 checks passed

Uhutown deleted the feats_UI/1.18 branch September 24, 2023 18:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Draft: Feats UI/1.18 #212

Draft: Feats UI/1.18 #212

Uhutown commented Aug 15, 2023

MrTroble Sep 20, 2023

Uhutown Sep 20, 2023

MrTroble Sep 20, 2023

MrTroble Sep 20, 2023

Uhutown Sep 20, 2023

MrTroble Sep 20, 2023

Uhutown Sep 20, 2023

MrTroble Sep 20, 2023

MrTroble Sep 20, 2023

Uhutown Sep 20, 2023

MrTroble Sep 20, 2023

MrTroble Sep 20, 2023

MrTroble Sep 20, 2023

Uhutown Sep 20, 2023

MrTroble Sep 20, 2023

MrTroble Sep 20, 2023

Uhutown Sep 20, 2023

MrTroble Sep 20, 2023

Draft: Feats UI/1.18 #212

Draft: Feats UI/1.18 #212

Conversation

Uhutown commented Aug 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment