Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and perform upgrade to bootstrap v5 #254

Open
jdrueckert opened this issue Sep 29, 2024 · 0 comments
Open

Investigate and perform upgrade to bootstrap v5 #254

jdrueckert opened this issue Sep 29, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jdrueckert
Copy link
Member

Dependabot found a vulnerability in our current bootstrap version: https://github.com/MovingBlocks/movingblocks.github.com/security/dependabot/146
The vulnerability affects the Carousel component which we're using for the Gallery.
We don't use the data-slide and data-slide-to attributes directly and from what I've seen, reactstrap doesn't use them either for their CarouselControl implementation. However, I don't know whether they are used by any of reactstrap's dependencies or any place else, so just to be sure, we should consider upgrading bootstrap to v5.

Upgrading bootstrap v5 would fix this issue, but that breaks the module list pagination (see screenshot below).
We need to figure out the breaking change and adjust our code accordingly if possible.

That's what the upgrade made it look like:
image

Should look like this instead:
image

@jdrueckert jdrueckert added bug Something isn't working help wanted Extra attention is needed labels Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant