Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More per-world saved data #950

Closed
Cervator opened this issue Feb 13, 2014 · 2 comments
Closed

More per-world saved data #950

Cervator opened this issue Feb 13, 2014 · 2 comments
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.

Comments

@Cervator
Copy link
Member

Currently we have a few things that are defined globally but used per-world, mainly the texture atlas and some parts of config.cfg

This can cause trouble like clashing hot keys between modules that aren't even enabled and texture overrides taking permanent effect based on which modules are loaded first (load a module with an override texture, create a world, then create a new world without the override and it is still in place)

More stuff should be moved to the individual world directories, including that world's block atlas and maybe module-specific key bindings? That way you could have two modules that use the same hot keys but do not save them to the global config, so you could run two different worlds, one with each of the modules, and both work without causing key conflicts

Still needs to be a way to resolve conflicts when multiple modules are active and use the same keys, of course

Maybe related: #335, #799, #813, #607, #763,

@Cervator Cervator added this to the Alpha! milestone Feb 13, 2014
@immortius
Copy link
Member

  1. The world texture atlas isn't defined globally, it is constructed per game. If you mean something else you'll have to elaborate.
  2. I added a "fix" for keys already, in so far as existing key binding take priority over the default bindings of new module buttons. It is up to the user to bind these buttons then. I'm not sure if there is a better way to deal with this, except maybe having a chain of defaults from preferred to least preferred? Having module specific key binds in the world is a bad idea, because that will be pretty much all key binds eventually, and means you'ld have to set your keys per game.
  3. Overrides is a legitimate problem, but it has nothing to do with per-world saved data. It has to do with proper asset cleanup.

@Cervator Cervator removed this from the Alpha! milestone Feb 14, 2014
@Cervator
Copy link
Member Author

Re-examined and with added clarifications on IRC yep this makes no sense after all. Disowning this from the alpha milestone, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.
Projects
None yet
Development

No branches or pull requests

2 participants