Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cython dependency? #25

Open
bcdarwin opened this issue Apr 12, 2016 · 2 comments
Open

remove cython dependency? #25

bcdarwin opened this issue Apr 12, 2016 · 2 comments

Comments

@bcdarwin
Copy link
Member

It's only used for 1 function, which is label-related -- does this really need Cython? We could get rid of the weirdness in our setup.py which never never installs properly ...
@mcvaneede
Copy link
Member

This program (replace_label_with_nearest_valid_label) is rarely run. So the speed at which it runs is not very important. Feel free to convert it to run simply in Python.

@bcdarwin bcdarwin reopened this Apr 14, 2016
@bcdarwin
Copy link
Member Author

In light of #35, we should keep Cython (if this is indeed the best route for TFCE). Of course, setup.py should still be revised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcdarwin @mcvaneede