Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with non-standard evaluation and callr #29

Open
rmflight opened this issue Dec 2, 2021 · 0 comments
Open

bug with non-standard evaluation and callr #29

rmflight opened this issue Dec 2, 2021 · 0 comments
Assignees

Comments

@rmflight
Copy link
Member

rmflight commented Dec 2, 2021

When using cc2 as part of an Rmarkdown report that is being managed by {callr} or a {drake} or {targets} workflow, and using a variable to hold a cutoff for significance, you may see the error that variable is not found (see reprex repo here).

This seems due to a less than ideal implementation of non-standard-evaluation on the part of the developer.
Because the significance call is really a filter operation, I think we should just depend on {dplyr::filter}, and pass the ... all the way down.
However, this means changing the statistical results to a proper data.frame, and other things.

To test the fix before mangling code across the statistical results class, etc, I think we should create a recursive function that upon reaching level 5 does the filtering and returns it, and verify it works via {callr}.

@rmflight rmflight self-assigned this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant