Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement options #1

Open
kevincardonag opened this issue Sep 7, 2022 · 1 comment
Open

Enhancement options #1

kevincardonag opened this issue Sep 7, 2022 · 1 comment

Comments

@kevincardonag
Copy link
Collaborator

kevincardonag commented Sep 7, 2022

Context: We want to improve our hiring process related to the time developers spend writing code for their interviews, we want to provide applicants with a code base where they can simulate working on a project that has already been developed.

Purposes of this ticket:

  • Identify the difference between our code implemented in Python (see here https://github.com/Monadical-SAS/python-side-stacker-base) with the current implementation in node, we want both to have the same functionalities.
  • Do this as an exercise to practice the developer's communication skills.
  • To find possible enhancement options for practicing node.js

These differences were found:

  1. In the node app you can select the player, it is a bit confusing when users try to start a game and It also has a disadvantage because the second player could enter to a player1’s room, so I think is better to have a username text field to avoid to enter to the wrong room.

image

  1. We are missing copy game id button in node project

image

  1. Minor changes
  • Add “side stacker” title as in the python project (see the image above)
  • When the game ends display an alert with winner's name and then return to the main page
  • Make sure it is no possible to enter a game without player name and game ID
@dearlordylord
Copy link
Collaborator

For the "copy game id" feature, pay attention to whether it'll work with a non-HTTPS address. I remember experiencing issues there on HTTP, which could be every applicant's environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants