Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic reverting to old position #14

Open
akoel opened this issue Feb 20, 2018 · 2 comments
Open

Automatic reverting to old position #14

akoel opened this issue Feb 20, 2018 · 2 comments
Assignees

Comments

@akoel
Copy link

akoel commented Feb 20, 2018

Love redux-time! I am using it with react-three-renderer and it works very well. However, currently an object automatically reverts to its old position after running the 'Animate' or 'Translate' function. I use 'Become' to set the position after doing the animation. I am not sure if this is best practice.

My suggestion would be to add a boolean option in the object passed into the 'Animate' or 'Translate' function with something like "revert: true/false". On "false" the end_state will be permanent in the Redux store.

@pirate
Copy link
Member

pirate commented Feb 21, 2018

The canonical solution is to set the end state with a Become as well, maybe I'll consider adding a flag.

@akoel akoel changed the title Feature request: no automatic reverting to old position Automatic reverting to old position Feb 23, 2018
@akoel akoel closed this as completed Feb 23, 2018
@pirate pirate reopened this Mar 10, 2018
@pirate
Copy link
Member

pirate commented Mar 10, 2018

We think adding a flag is actually a great idea, as it's more intuitive than a second Become at the end, so we'll be implementing this at some point. Thanks for the suggestion @akoel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants