Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change E016 error to warning for ADDED trips #79

Open
isabelle-dr opened this issue Jan 9, 2022 · 1 comment
Open

Change E016 error to warning for ADDED trips #79

isabelle-dr opened this issue Jan 9, 2022 · 1 comment
Labels
enhancement GTFS RT Best Practices Used for issues or pull requests related to GTFS RT Best Practices imported
Milestone

Comments

@isabelle-dr
Copy link

isabelle-dr commented Jan 9, 2022

Issue by barbeau
Sept 11, 2020
Originally opened as CUTR-at-USF#384


Summary:

We currently have E016 for ADDED trips:
https://github.com/CUTR-at-USF/gtfs-realtime-validator/blob/master/RULES.md#E016

ADDED has recently been marked as "unspecified" in GTFS-realtime, which means that the exact behavior isn't defined:
google/transit#230

We should probably remove this error, as some producers could consider this case valid, and instead have a warning that ADDED trips are unspecified and behavior of consumers isn't consistent.

Steps to reproduce:

Run the validator

Expected behavior:

Don't throw errors on unspecified behavior

Observed behavior:

ADDED is now unspecified in GTFS-RT, but we throw errors on it based on our past assumption of how it works (which, it turns out, others disagree with - google/transit#230).

@isabelle-dr isabelle-dr added this to the v1.0 milestone Jan 9, 2022
@barbeau barbeau changed the title Remove E016 for ADDED trips Change E016 error to warning for ADDED trips Feb 25, 2022
@barbeau
Copy link
Member

barbeau commented Mar 24, 2022

As mentioned in #122, the current Best Practice text is:

TripDescriptor.schedule_relationship: The behavior of ADDED trips are unspecified and the use of this enumeration is not recommended.

@e-lo e-lo added the GTFS RT Best Practices Used for issues or pull requests related to GTFS RT Best Practices label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GTFS RT Best Practices Used for issues or pull requests related to GTFS RT Best Practices imported
Projects
None yet
Development

No branches or pull requests

3 participants