Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid can't build #582

Closed
licaon-kter opened this issue Jul 5, 2024 · 5 comments
Closed

F-Droid can't build #582

licaon-kter opened this issue Jul 5, 2024 · 5 comments

Comments

@licaon-kter
Copy link

licaon-kter commented Jul 5, 2024

..as you've removed the custom versionCode code: 1.2.8...main#diff-9526ccfd1d1813ed49c39f8c54dbeb512607376a007d824b905bc8b4e4d202d9L104 and it went back to Flutter defaults

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/7270851929#L935

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/99d4dbeeeece4cbfd47828bb6a7a9037fbf29ad0

@danemadsen
Copy link
Member

I'm looking into it. I removed that because for some reason its broken on the latest versions of flutter which I've which i had to move to.

I had a look at some other flutter open source projects and i cant really see how they've fixed it or they might just be on flutter 3.19 still.

@danemadsen
Copy link
Member

@licaon-kter Ok ive fixed that error but im going to have to change the way build numbers work because google play wont let me upload 2 app bundles with a version code of 29. So... Im switching to using git index's as the build number so this release will be 16971 and 16972. I hope that works with fdroid because i have no other option

@licaon-kter
Copy link
Author

If it's bigger than older and if arch number is last, yes :)

@danemadsen
Copy link
Member

@licaon-kter Ok, Ive republished that for you. While im at it i should probably change the name of the apk's from maid-x86_64.apk and maid-arm64-v8a.apk to maid-android-x86_64.apk and maid-android-arm64-v8a.apk as im releasing more platforms and the release page gets confusing.

Would you like me to open up a PR for you or do you want to handle it yourself?

@linsui
Copy link

linsui commented Jul 6, 2024

A PR is welcomed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants