Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the model in code matches what is described in the paper? #3

Open
YuanTingHsieh opened this issue Jun 22, 2018 · 1 comment
Open

Comments

@YuanTingHsieh
Copy link

In the first attention block,
You get hidden features using a filter AttnW to conv. with state outputs,
I believe that's the formula W h_k,
BUT you also have state outputs pass through a linear layer and get y
Then you add y and hidden features then pass through an tanh then multiply by a matrix

In the paper, I only see tanh(W h_k)

Also in your code there is AttnV,
where I can't find corresponding description in the paper.

The paper only has gate V and gate W

Could you kindly explain this?
I am really confusing.
Thank you!

@YuanTingHsieh YuanTingHsieh changed the title Is the model in code match what describes in the paper? Is the model in code matches what is described in the paper? Jun 22, 2018
@nwy2010
Copy link

nwy2010 commented Aug 31, 2019

Yes, I have the same doubts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants