[pull] master from magma:master #2838
reviewdog [shellcheck] report
reported by reviewdog 🐶
Findings (36)
nms/e2e_test_setup.sh|24 col 73| Consider using 'grep -c' instead of 'grep|wc -l'.
nms/e2e_test_setup.sh|25 col 10| Double quote to prevent globbing and word splitting.
nms/e2e_test_setup.sh|31 col 7| Use
nms/e2e_test_setup.sh|31 col 9|
lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh|16 col 8| Not following: /var/opt/magma/docker/.env: openBinaryFile: does not exist (No such file or directory)
lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh|23 col 22| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|45 col 18| Double quote to prevent globbing and word splitting.
lte/gateway/docker/ghz/publish.sh|18 col 29| Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A"B"C"?
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|58 col 7| Use -n instead of ! -z.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|59 col 33| The surrounding quotes actually unquote this. Remove or escape them.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|59 col 33| Double quote to prevent globbing and word splitting.
bazel/scripts/test_python_service_imports.sh|46 col 9| Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
bazel/scripts/run_sudo_tests.sh|57 col 9| Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
bazel/scripts/run_sudo_tests.sh|133 col 7| Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
third_party/build/bin/aioh2_build.sh|18 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/aioh2_build.sh|37 col 8| Not following: env/bin/activate: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/bcc_build.sh|17 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/bcc_build.sh|22 col 1| VERSION appears unused. Verify use (or export if used externally).
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|15 col 38| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|15 col 38| Use $(...) notation instead of legacy backticks ...
.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|39 col 38| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|39 col 38| Use $(...) notation instead of legacy backticks ...
.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|51 col 42| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|51 col 42| Use $(...) notation instead of legacy backticks ...
.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|73 col 39| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|73 col 39| Use $(...) notation instead of legacy backticks ...
.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|74 col 39| Quote this to prevent word splitting.
third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh|74 col 39| Use $(...) notation instead of legacy backticks ...
.
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|23 col 10|
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|29 col 10|
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|34 col 11| Use $(...) notation instead of legacy backticks ...
.
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|44 col 15| Use $(...) notation instead of legacy backticks ...
.
orc8r/tools/packer/scripts/third_party/aspyatkin/minimize_ubuntu.sh|44 col 46| Double quote to prevent globbing and word splitting.
orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh|22 col 15| Quote this to prevent word splitting.
orc8r/tools/packer/scripts/third_party/chef_bento/cleanup_ubuntu.sh|22 col 15| Use $(...) notation instead of legacy backticks ...
.
.devcontainer/post-create-commands.sh|12 col 51| Quote this to prevent word splitting.
Filtered Findings (411)
cn/deploy/scripts/fluentd_install.sh|16 col 1| PASSWD appears unused. Verify use (or export if used externally).
cn/deploy/scripts/fluentd_install.sh|27 col 95| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_install.sh|28 col 91| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_install.sh|124 col 92| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_install.sh|125 col 96| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_install.sh|126 col 2| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
cn/deploy/scripts/fluentd_install.sh|131 col 2| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
cn/deploy/scripts/fluentd_install.sh|137 col 2| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
cn/deploy/scripts/fluentd_prerequisites.sh|16 col 1| PASSWD appears unused. Verify use (or export if used externally).
cn/deploy/scripts/fluentd_prerequisites.sh|21 col 77| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_prerequisites.sh|22 col 262| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_prerequisites.sh|24 col 2| Consider using { cmd1; cmd2; } >> file instead of individual redirects.
cn/deploy/scripts/fluentd_prerequisites.sh|24 col 7| Expressions don't expand in single quotes, use double quotes for that.
cn/deploy/scripts/fluentd_prerequisites.sh|25 col 7| Expressions don't expand in single quotes, use double quotes for that.
cn/deploy/scripts/fluentd_prerequisites.sh|27 col 94| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/fluentd_prerequisites.sh|29 col 9| ShellCheck can't follow non-constant source. Use a directive to specify location.
cn/deploy/scripts/script.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
cn/deploy/scripts/script.sh|12 col 7| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/script.sh|13 col 36| Double quote to prevent globbing and word splitting.
cn/deploy/scripts/script.sh|14 col 12| Quote this to prevent word splitting.
cn/deploy/scripts/script.sh|14 col 21| Quote this to prevent word splitting.
cn/deploy/scripts/script.sh|14 col 30| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|45 col 28| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|52 col 30| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|57 col 32| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|66 col 30| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|66 col 52| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|66 col 84| Expressions don't expand in single quotes, use double quotes for that.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|67 col 22| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|68 col 22| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|69 col 22| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|70 col 26| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|71 col 26| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|72 col 31| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|72 col 53| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|72 col 85| Expressions don't expand in single quotes, use double quotes for that.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|79 col 12| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/pre-upgrade-migration.sh|79 col 34| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/runs-on-nms.sh|53 col 1| Use 'popd ... || exit' or 'popd ... || return' in case popd fails.
nms/scripts/fuji-upgrade/runs-on-nms.sh|66 col 27| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/runs-on-nms.sh|66 col 44| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/runs-on-nms.sh|66 col 65| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/runs-on-nms.sh|66 col 83| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/runs-on-nms.sh|66 col 107| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/runs-on-nms.sh|66 col 132| Double quote to prevent globbing and word splitting.
nms/scripts/fuji-upgrade/runs-on-nms.sh|67 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
nms/wait-for-it.sh|59 col 19| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|59 col 35| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|62 col 30| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|62 col 46| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|72 col 12| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|79 col 41| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|79 col 60| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|79 col 86| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|79 col 109| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|79 col 135| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|81 col 41| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|81 col 60| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|81 col 78| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|81 col 101| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|81 col 127| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|84 col 22| Use single quotes, otherwise this expands now rather than when signalled.
nms/wait-for-it.sh|98 col 29| Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
nms/wait-for-it.sh|169 col 35| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|169 col 86| Double quote to prevent globbing and word splitting.
nms/wait-for-it.sh|199 col 7| Expanding an array without an index only gives the first element.
feg/radius/src/run.sh|25 col 10| Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
lte/gateway/deploy/roles/magma_test/files/build_s1_tester.sh|16 col 32| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/clone_s1_tester.sh|35 col 4| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
lte/gateway/deploy/roles/magma_test/files/clone_s1_tester.sh|35 col 7| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|18 col 1| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|23 col 22| Grep uses regex, but this looks like a glob.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|27 col 25| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|27 col 47| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|28 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|34 col 1| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma_test/files/update_package.sh|39 col 6| Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
lte/gateway/deploy/roles/magma/files/ovs-kmod-upgrade.sh|21 col 9| read without -r will mangle backslashes.
lte/gateway/deploy/roles/magma/files/ovs-kmod-upgrade.sh|56 col 9| read without -r will mangle backslashes.
lte/gateway/deploy/roles/magma/files/magma-create-gtp-port.sh|23 col 45| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma/files/magma-create-gtp-port.sh|23 col 73| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma/files/magma-create-gtp-port.sh|23 col 112| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma/files/magma-create-gtp-port.sh|23 col 150| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma/files/magma-create-gtp-port.sh|23 col 173| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma/files/magma-create-gtp-port.sh|26 col 33| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/roles/magma/files/configure_envoy_namespace.sh|40 col 76| Double quote to prevent globbing and word splitting.
lte/gateway/deploy/agw_install_ubuntu.sh|49 col 9| read without -r will mangle backslashes.
lte/gateway/deploy/agw_install_ubuntu.sh|150 col 22| Double quote to prevent globbing and word splitting.
lte/gateway/release/upgrade_magma.sh|15 col 5| read without -r will mangle backslashes.
lte/gateway/release/build-magma.sh|19 col 1| SCRIPT_DIR appears unused. Verify use (or export if used externally).
lte/gateway/release/build-magma.sh|58 col 5| CERT_FILE appears unused. Verify use (or export if used externally).
lte/gateway/release/build-magma.sh|70 col 43| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|87 col 40| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|98 col 38| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|106 col 1| BUILD_DATE appears unused. Verify use (or export if used externally).
lte/gateway/release/build-magma.sh|106 col 12| Use $(...) notation instead of legacy backticks ...
.
lte/gateway/release/build-magma.sh|181 col 38| The surrounding quotes actually unquote this. Remove or escape them.
lte/gateway/release/build-magma.sh|185 col 38| The surrounding quotes actually unquote this. Remove or escape them.
lte/gateway/release/build-magma.sh|189 col 38| The surrounding quotes actually unquote this. Remove or escape them.
lte/gateway/release/build-magma.sh|205 col 5| Use $(...) notation instead of legacy backticks ...
.
lte/gateway/release/build-magma.sh|229 col 10| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|284 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|287 col 4| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|292 col 15| Use $(...) notation instead of legacy backticks ...
.
lte/gateway/release/build-magma.sh|292 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|292 col 46| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|292 col 76| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|294 col 4| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|299 col 1| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|299 col 33| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|299 col 63| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|300 col 13| Use $(...) notation instead of legacy backticks ...
.
lte/gateway/release/build-magma.sh|300 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|300 col 44| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|300 col 74| Double quote to prevent globbing and word splitting.
lte/gateway/release/build-magma.sh|306 col 4| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|13 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|15 col 9| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|16 col 9| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|18 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|19 col 11| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|22 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|23 col 13| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|28 col 12| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|32 col 21| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|36 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|37 col 20| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|41 col 73| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|41 col 99| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|43 col 34| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|44 col 22| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|44 col 56| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|44 col 84| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|45 col 33| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|47 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|50 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|51 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|51 col 103| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|52 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/bridge.sh|66 col 23| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|16 col 15| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|18 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|20 col 38| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|23 col 27| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|25 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|26 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|27 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|29 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|29 col 54| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|29 col 65| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|29 col 81| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|37 col 17| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|37 col 68| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|38 col 13| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|39 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|41 col 20| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|46 col 14| Iterating over ls output is fragile. Use globs.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|49 col 9| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|57 col 16| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|57 col 61| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/script/sim-ue/sim-ue.sh|60 col 5| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/envoy-tests/setup-envoy-cntr.sh|3 col 1| envoy_ns appears unused. Verify use (or export if used externally).
lte/gateway/python/magma/pipelined/tests/envoy-tests/install-envoy.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
lte/gateway/python/magma/pipelined/tests/envoy-tests/setup-net-http.sh|5 col 1| envoy_port appears unused. Verify use (or export if used externally).
lte/gateway/python/magma/pipelined/tests/envoy-tests/setup-envoy.sh|3 col 1| envoy_ns appears unused. Verify use (or export if used externally).
lte/gateway/python/magma/pipelined/tests/envoy-tests/envoy-service.sh|43 col 64| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/pipelined/tests/envoy-tests/pkt-routing-setup.sh|1 col 1| Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-sw.sh|20 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|44 col 89| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|45 col 51| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|46 col 54| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|56 col 14| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|56 col 26| Double quote to prevent globbing and word splitting.
lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh|68 col 7| Use -n instead of ! -z.
third_party/build/bin/nettle_build.sh|20 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/nettle_build.sh|24 col 1| VERSION appears unused. Verify use (or export if used externally).
third_party/build/bin/nettle_build.sh|37 col 14| Use $(...) notation instead of legacy backticks ...
.
third_party/build/bin/nettle_build.sh|57 col 8| Quote this to prevent word splitting.
third_party/build/bin/nettle_build.sh|57 col 8| Use $(...) notation instead of legacy backticks ...
.
third_party/build/bin/nettle_build.sh|65 col 9| Double quote to prevent globbing and word splitting.
third_party/build/bin/nettle_build.sh|66 col 6| Double quote to prevent globbing and word splitting.
third_party/build/bin/nettle_build.sh|71 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/nettle_build.sh|72 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/nettle_build.sh|79 col 15| Double quote to prevent globbing and word splitting.
third_party/build/bin/prometheus-cpp_build.sh|23 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/prometheus-cpp_build.sh|44 col 14| Use $(...) notation instead of legacy backticks ...
.
third_party/build/bin/prometheus-cpp_build.sh|73 col 8| Quote this to prevent word splitting.
third_party/build/bin/prometheus-cpp_build.sh|77 col 1| COMMIT_TIMESTAMP appears unused. Verify use (or export if used externally).
third_party/build/bin/prometheus-cpp_build.sh|78 col 1| COMMIT_HASH appears unused. Verify use (or export if used externally).
third_party/build/bin/prometheus-cpp_build.sh|85 col 9| Double quote to prevent globbing and word splitting.
third_party/build/bin/prometheus-cpp_build.sh|86 col 6| Double quote to prevent globbing and word splitting.
third_party/build/bin/prometheus-cpp_build.sh|91 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/prometheus-cpp_build.sh|92 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/prometheus-cpp_build.sh|94 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/prometheus-cpp_build.sh|99 col 15| Double quote to prevent globbing and word splitting.
third_party/build/bin/liblfds_build.sh|20 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/liblfds_build.sh|24 col 1| VERSION appears unused. Verify use (or export if used externally).
third_party/build/bin/liblfds_build.sh|34 col 14| Use $(...) notation instead of legacy backticks ...
.
third_party/build/bin/liblfds_build.sh|68 col 9| Double quote to prevent globbing and word splitting.
third_party/build/bin/liblfds_build.sh|69 col 6| Double quote to prevent globbing and word splitting.
third_party/build/bin/liblfds_build.sh|74 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/liblfds_build.sh|75 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/liblfds_build.sh|82 col 15| Double quote to prevent globbing and word splitting.
third_party/build/bin/magma-cpp-redis_build.sh|20 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/magma-cpp-redis_build.sh|25 col 1| VERSION appears unused. Verify use (or export if used externally).
third_party/build/bin/magma-cpp-redis_build.sh|46 col 14| Use $(...) notation instead of legacy backticks ...
.
third_party/build/bin/magma-cpp-redis_build.sh|76 col 9| Double quote to prevent globbing and word splitting.
third_party/build/bin/magma-cpp-redis_build.sh|77 col 6| Double quote to prevent globbing and word splitting.
third_party/build/bin/magma-cpp-redis_build.sh|82 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/magma-cpp-redis_build.sh|83 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/magma-cpp-redis_build.sh|90 col 15| Double quote to prevent globbing and word splitting.
third_party/build/bin/folly_build.sh|20 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/folly_build.sh|25 col 1| VERSION appears unused. Verify use (or export if used externally).
third_party/build/bin/folly_build.sh|73 col 14| Use $(...) notation instead of legacy backticks ...
.
third_party/build/bin/folly_build.sh|123 col 9| Quote this to prevent word splitting.
third_party/build/bin/folly_build.sh|138 col 9| Double quote to prevent globbing and word splitting.
third_party/build/bin/folly_build.sh|139 col 6| Double quote to prevent globbing and word splitting.
third_party/build/bin/folly_build.sh|144 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/folly_build.sh|145 col 8| Double quote to prevent globbing and word splitting.
third_party/build/bin/folly_build.sh|154 col 15| Double quote to prevent globbing and word splitting.
third_party/build/bin/freediameter_build.sh|17 col 8| Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
third_party/build/bin/freediameter_build.sh|22 col 1| VERSION appears unused. Verify use (or export if used externally).
third_party/build/bin/freediameter_build.sh|43 col 14| Use $(...) notation instead of legacy backticks ...
.
third_party/build/bin/freediameter_build.sh|73 col 8| Quote this to prevent word splitting.
... (Too many findings. Dropped some findings)
Annotations
Check notice on line 24 in nms/e2e_test_setup.sh
github-actions / shellcheck
[shellcheck] nms/e2e_test_setup.sh#L24 <ShellCheck.SC2126>
Consider using 'grep -c' instead of 'grep|wc -l'.
Raw output
./nms/e2e_test_setup.sh:24:73: info: Consider using 'grep -c' instead of 'grep|wc -l'. (ShellCheck.SC2126)
Check notice on line 25 in nms/e2e_test_setup.sh
github-actions / shellcheck
[shellcheck] nms/e2e_test_setup.sh#L25 <ShellCheck.SC2086>
Double quote to prevent globbing and word splitting.
Raw output
./nms/e2e_test_setup.sh:25:10: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
Check notice on line 31 in nms/e2e_test_setup.sh
github-actions / shellcheck
[shellcheck] nms/e2e_test_setup.sh#L31 <ShellCheck.SC2007>
Use $((..)) instead of deprecated $[..]
Raw output
./nms/e2e_test_setup.sh:31:7: info: Use $((..)) instead of deprecated $[..] (ShellCheck.SC2007)
Check notice on line 31 in nms/e2e_test_setup.sh
github-actions / shellcheck
[shellcheck] nms/e2e_test_setup.sh#L31 <ShellCheck.SC2004>
$/${} is unnecessary on arithmetic variables.
Raw output
./nms/e2e_test_setup.sh:31:9: info: $/${} is unnecessary on arithmetic variables. (ShellCheck.SC2004)
Check notice on line 16 in lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh
github-actions / shellcheck
[shellcheck] lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh#L16 <ShellCheck.SC1091>
Not following: /var/opt/magma/docker/.env: openBinaryFile: does not exist (No such file or directory)
Raw output
./lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh:16:8: info: Not following: /var/opt/magma/docker/.env: openBinaryFile: does not exist (No such file or directory) (ShellCheck.SC1091)
Check notice on line 23 in lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh
github-actions / shellcheck
[shellcheck] lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh#L23 <ShellCheck.SC2086>
Double quote to prevent globbing and word splitting.
Raw output
./lte/gateway/deploy/roles/agw_docker/files/agw_upgrade.sh:23:22: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
Check notice on line 45 in lte/gateway/deploy/roles/magma_test/files/update_package.sh
github-actions / shellcheck
[shellcheck] lte/gateway/deploy/roles/magma_test/files/update_package.sh#L45 <ShellCheck.SC2086>
Double quote to prevent globbing and word splitting.
Raw output
./lte/gateway/deploy/roles/magma_test/files/update_package.sh:45:18: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
Check warning on line 18 in lte/gateway/docker/ghz/publish.sh
github-actions / shellcheck
[shellcheck] lte/gateway/docker/ghz/publish.sh#L18 <ShellCheck.SC2140>
Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"?
Raw output
./lte/gateway/docker/ghz/publish.sh:18:29: warning: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A\"B\"C"? (ShellCheck.SC2140)
Check notice on line 58 in lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh
github-actions / shellcheck
[shellcheck] lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh#L58 <ShellCheck.SC2236>
Use -n instead of ! -z.
Raw output
./lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh:58:7: info: Use -n instead of ! -z. (ShellCheck.SC2236)
Check warning on line 59 in lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh
github-actions / shellcheck
[shellcheck] lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh#L59 <ShellCheck.SC2027>
The surrounding quotes actually unquote this. Remove or escape them.
Raw output
./lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh:59:33: warning: The surrounding quotes actually unquote this. Remove or escape them. (ShellCheck.SC2027)
Check notice on line 59 in lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh
github-actions / shellcheck
[shellcheck] lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh#L59 <ShellCheck.SC2086>
Double quote to prevent globbing and word splitting.
Raw output
./lte/gateway/python/magma/mobilityd/scripts/setup-uplink-vlan-srv.sh:59:33: info: Double quote to prevent globbing and word splitting. (ShellCheck.SC2086)
Check notice on line 46 in bazel/scripts/test_python_service_imports.sh
github-actions / shellcheck
[shellcheck] bazel/scripts/test_python_service_imports.sh#L46 <ShellCheck.SC2317>
Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
Raw output
./bazel/scripts/test_python_service_imports.sh:46:9: info: Command appears to be unreachable. Check usage (or ignore if invoked indirectly). (ShellCheck.SC2317)
Check notice on line 57 in bazel/scripts/run_sudo_tests.sh
github-actions / shellcheck
[shellcheck] bazel/scripts/run_sudo_tests.sh#L57 <ShellCheck.SC2317>
Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
Raw output
./bazel/scripts/run_sudo_tests.sh:57:9: info: Command appears to be unreachable. Check usage (or ignore if invoked indirectly). (ShellCheck.SC2317)
Check notice on line 133 in bazel/scripts/run_sudo_tests.sh
github-actions / shellcheck
[shellcheck] bazel/scripts/run_sudo_tests.sh#L133 <ShellCheck.SC2317>
Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
Raw output
./bazel/scripts/run_sudo_tests.sh:133:7: info: Command appears to be unreachable. Check usage (or ignore if invoked indirectly). (ShellCheck.SC2317)
Check notice on line 18 in third_party/build/bin/aioh2_build.sh
github-actions / shellcheck
[shellcheck] third_party/build/bin/aioh2_build.sh#L18 <ShellCheck.SC1091>
Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
Raw output
./third_party/build/bin/aioh2_build.sh:18:8: info: Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory) (ShellCheck.SC1091)
Check notice on line 37 in third_party/build/bin/aioh2_build.sh
github-actions / shellcheck
[shellcheck] third_party/build/bin/aioh2_build.sh#L37 <ShellCheck.SC1091>
Not following: env/bin/activate: openBinaryFile: does not exist (No such file or directory)
Raw output
./third_party/build/bin/aioh2_build.sh:37:8: info: Not following: env/bin/activate: openBinaryFile: does not exist (No such file or directory) (ShellCheck.SC1091)
Check notice on line 17 in third_party/build/bin/bcc_build.sh
github-actions / shellcheck
[shellcheck] third_party/build/bin/bcc_build.sh#L17 <ShellCheck.SC1091>
Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory)
Raw output
./third_party/build/bin/bcc_build.sh:17:8: info: Not following: ./../lib/util.sh: openBinaryFile: does not exist (No such file or directory) (ShellCheck.SC1091)
Check warning on line 22 in third_party/build/bin/bcc_build.sh
github-actions / shellcheck
[shellcheck] third_party/build/bin/bcc_build.sh#L22 <ShellCheck.SC2034>
VERSION appears unused. Verify use (or export if used externally).
Raw output
./third_party/build/bin/bcc_build.sh:22:1: warning: VERSION appears unused. Verify use (or export if used externally). (ShellCheck.SC2034)
Check warning on line 15 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh
github-actions / shellcheck
[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L15 <ShellCheck.SC2046>
Quote this to prevent word splitting.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:15:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)
Check notice on line 15 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh
github-actions / shellcheck
[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L15 <ShellCheck.SC2006>
Use $(...) notation instead of legacy backticks `...`.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:15:38: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
Check warning on line 39 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh
github-actions / shellcheck
[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L39 <ShellCheck.SC2046>
Quote this to prevent word splitting.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:39:38: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)
Check notice on line 39 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh
github-actions / shellcheck
[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L39 <ShellCheck.SC2006>
Use $(...) notation instead of legacy backticks `...`.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:39:38: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
Check warning on line 51 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh
github-actions / shellcheck
[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L51 <ShellCheck.SC2046>
Quote this to prevent word splitting.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:51:42: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)
Check notice on line 51 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh
github-actions / shellcheck
[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L51 <ShellCheck.SC2006>
Use $(...) notation instead of legacy backticks `...`.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:51:42: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
Check warning on line 73 in third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh
github-actions / shellcheck
[shellcheck] third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh#L73 <ShellCheck.SC2046>
Quote this to prevent word splitting.
Raw output
./third_party/gtp_ovs/ovs-gtp-patches/2.15/dev.sh:73:39: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)