Extend helm chart configuration for Templates #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes in the
ClusterTemplate
,ServiceTemplate
, andProviderTemplate
spec:spec.helm.chart
section of the HelmChartSpec type to support providing extended helm chart configuration. An example of the simplest allowed configuration:An example of the extended configuration with the source
The
version
parameter is optional (the latest chart version will be used if unset). ThesourceRef
andinterval
parameters from thespec.helm.chart
will be automatically populated with defaults if unset:where
hmc-templates
is the name of the defaultHelmRepository
created by the hmc controller.spec.helm.chartName
andspec.helm.chartVersion
parameters were removed as unnecessary.Closes #615