Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend helm chart configuration for Templates #699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eromanova
Copy link
Member

@eromanova eromanova commented Nov 28, 2024

This PR introduces the following changes in the ClusterTemplate, ServiceTemplate, and ProviderTemplate spec:

  • New spec.helm.chart section of the HelmChartSpec type to support providing extended helm chart configuration. An example of the simplest allowed configuration:
spec:
  helm:
    chart:
      chart: chart-name

An example of the extended configuration with the source

spec:
  helm:
    chart:
      chart: chart-name
      version: 1.0.0
      interval: 15m0s
      sourceRef:
        kind: HelmRepository
        name: helm-repo

The version parameter is optional (the latest chart version will be used if unset). The sourceRef and interval parameters from the spec.helm.chart will be automatically populated with defaults if unset:

interval: 10m0s
sourceRef:
  kind: HelmRepository
  name: hmc-templates

where hmc-templates is the name of the default HelmRepository created by the hmc controller.

  • The spec.helm.chartName and spec.helm.chartVersion parameters were removed as unnecessary.

Closes #615

@eromanova eromanova self-assigned this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Simplify BYO Templates
1 participant