Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Mount Propagation in ContainerStatus #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afbjorklund
Copy link
Contributor

This was "commented out" in the dockershim tests (of critest)

kubernetes-sigs/cri-tools@4bb6714#diff-fb3f779b47c369fad04d8812ff6e9d8fa84fd10dededf3bea1cf6de29b6f7ecdR258

        // NOTE: dockershim does not populate that field, so we do not have to test it
        if framework.TestContext.RuntimeServiceAddr != framework.DockerShimSockPathUnix &&
                framework.TestContext.RuntimeServiceAddr != framework.DockerShimSockPathWindows {
                By("verifying container status mount propagation")
                Expect(resp.Status.Mounts[0].Propagation).To(Equal(propagation))
        }

@afbjorklund
Copy link
Contributor Author

afbjorklund commented Jun 28, 2024

Still broken, with v1.30.0

Summarizing 2 Failures:
  [FAIL] [k8s.io] Container Mount Propagation runtime should support mount propagation [It] mount with 'rshared' should support propagation from host to container and vice versa
  github.com/kubernetes-sigs/cri-tools/pkg/validate/container_linux.go:265
  [FAIL] [k8s.io] Container Mount Propagation runtime should support mount propagation [It] mount with 'rslave' should support propagation from host to container
  github.com/kubernetes-sigs/cri-tools/pkg/validate/container_linux.go:265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant