Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the release versions to use a git tag #251

Closed
nwneisen opened this issue Oct 10, 2023 · 1 comment
Closed

Change the release versions to use a git tag #251

nwneisen opened this issue Oct 10, 2023 · 1 comment
Labels
build good first issue Good for newcomers

Comments

@nwneisen
Copy link
Collaborator

Expected Behavior

When creating a release, it would be nice to tag the latest commit on master with the release version and then have the code base automatically use this tag for the generated files.

Care should be taken to make sure that an alternative version is used when doing a dev build. This way it at least takes effort to create versions of a release.

Actual Behavior

The current process involves creating a PR to bump the version in

  • VERSION
  • version.go
  • common.mk

The extra PR is unnecessary paperwork. These can be modified to just pull the latest tag that matches semantic versioning

@nwneisen nwneisen added good first issue Good for newcomers build labels Oct 10, 2023
@nwneisen
Copy link
Collaborator Author

This was done as part of #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant