Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install extra requirements for thumbor #161

Closed
wants to merge 1 commit into from
Closed

Install extra requirements for thumbor #161

wants to merge 1 commit into from

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Sep 3, 2024

Fixes #160

numpy 2 was getting installed rather than numpy 1, so I'm trying to tweak the requirements file to fix that. thumbor lists numpy in it's extra_require list, so I'm trying to opt into that using the [tag] syntax.

This also lets us move the list of extra requirements (cairosvg, pycurl, pillow-avif-plugin) from the requirements file to thumbor's setup.py. We now also pull in pillow-heif to support heif output.


I'm not super familiar with pip and dockerfiles so I might've gotten something wrong here. Please help me test it out!

@gingerlime
Copy link
Contributor

Thanks so much. Looks much cleaner as well 👍 Merged via #162

@gingerlime gingerlime closed this Sep 3, 2024
@NotWoods NotWoods deleted the extras_require branch September 3, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong version of numpy is installed
2 participants