Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adds SDK unit tests and CI task #105

Merged
merged 19 commits into from
Nov 21, 2024
Merged

test: Adds SDK unit tests and CI task #105

merged 19 commits into from
Nov 21, 2024

Conversation

miquelbeltran
Copy link
Contributor

@miquelbeltran miquelbeltran commented Nov 19, 2024

  • Adds SDK unit tests.
    • The Test file contains two basic tests:
        1. checks if send error worked correctly and data is passed,
        1. checks that the error is stored in "async storage" if the error fails to send.
  • While implementing the tests, I found that some methods were not properly awaited.
  • I have also setup the prettier formatter, since I got some formatting inconsistency while editing SDK files, so the PR is a big bigger than I originally planned.
  • I have also setup CI jobs to run test and the prettier check, based on what we do in raygun4node.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding dev dependencies for running tests, as well as fixed the prettier command to include tests and mocks

Copy link

@TheRealAgentK TheRealAgentK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miquelbeltran miquelbeltran merged commit a398d24 into master Nov 21, 2024
8 checks passed
@miquelbeltran miquelbeltran deleted the unit-tests branch November 21, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants