Add typescript types and onboarding ping #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olwiba
requested changes
Apr 18, 2024
Olwiba
previously approved these changes
Apr 18, 2024
PanosNB
requested changes
May 15, 2024
PanosNB
previously approved these changes
May 15, 2024
src/raygun.loader.js
Outdated
| // Request failed | ||
| metadata.ping.failedPings++; | ||
| } | ||
| }) |
There was a problem hiding this comment.
This is a bit ugly here, we normally put the .catch in the line. No worries for now
PanosNB
previously approved these changes
May 16, 2024
phillip-haydon
requested changes
May 17, 2024
CmdrKeen
reviewed
May 28, 2024
bower.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "raygun4js", | |||
| "version": "2.28.0", | |||
| "version": "3.1.1", | |||
There was a problem hiding this comment.
@Hamish-taylor Update this please (as you suggested)
CmdrKeen
reviewed
May 28, 2024
package.json
Outdated
| ], | ||
| "title": "Raygun4js", | ||
| "description": "Raygun.com plugin for JavaScript", | ||
| "version": "3.0.1", | ||
| "version": "3.1.1", |
There was a problem hiding this comment.
@Hamish-taylor Update here too :)
CmdrKeen
previously approved these changes
May 28, 2024
There was a problem hiding this comment.
Looks good to me @Hamish-taylor - just updates on the version numbers.
CmdrKeen
previously approved these changes
May 29, 2024
JasenPalmer
reviewed
May 29, 2024
Co-authored-by: Jasen Palmer <[email protected]>
PanosNB
approved these changes
Jun 4, 2024
phillip-haydon
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.