Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SSLContext to be provided #70

Open
DanFTRX opened this issue Dec 26, 2019 · 2 comments
Open

Allow SSLContext to be provided #70

DanFTRX opened this issue Dec 26, 2019 · 2 comments
Assignees
Milestone

Comments

@DanFTRX
Copy link

DanFTRX commented Dec 26, 2019

Raygun uses OkHttpClient to make it's posts.

Use Case:

  • We have overridden the endpoint to a different endpoint
  • The certificates involved are not be trusted by the phones default CA's (internal network)

Problem:
The default SSLContext will fail to handshake and the requests will fail.

Solution:
Allow a SSLContext to be supplied to RaygunSettings that will be set on the OKHttpClient:

    new OkHttpClient.Builder()
     .sslSocketFactory(sslContext.getSocketFactory())

This would be needed in both post services
https://github.com/MindscapeHQ/raygun4android/blob/master/provider/src/main/java/com/raygun/raygun4android/services/CrashReportingPostService.java#L114
https://github.com/MindscapeHQ/raygun4android/blob/master/provider/src/main/java/com/raygun/raygun4android/services/RUMPostService.java#L69

@TheRealAgentK TheRealAgentK self-assigned this May 2, 2022
@TheRealAgentK TheRealAgentK added this to the 5.0 milestone May 2, 2022
@TheRealAgentK
Copy link
Contributor

Todo: look into not using OKHttp and remove the dependency completely in favour some some URLConnection class.

@TheRealAgentK TheRealAgentK removed their assignment Jul 3, 2024
@TheRealAgentK
Copy link
Contributor

Todo: look into not using OKHttp and remove the dependency completely in favour some some URLConnection class.

Let's not do this. But will look into sslContext changes again now.

@TheRealAgentK TheRealAgentK self-assigned this Oct 11, 2024
@TheRealAgentK TheRealAgentK modified the milestones: 5.0, 4.1 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants