Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #4

Open
tchaton opened this issue Apr 27, 2021 · 0 comments
Open

Cleanup #4

tchaton opened this issue Apr 27, 2021 · 0 comments

Comments

@tchaton
Copy link

tchaton commented Apr 27, 2021

Dear @MilesCranmer,

Awesome work with this repo.

I really like how you are using jax to generate the data and PyTorch Geometric for the model.
I think you could have made your code even cleaner if you used PyTorch Lightning.
We worked with Matthias Fey to better support PyTorch Geometric and working DGL team right now for the same purpose.

Find examples there: https://github.com/rusty1s/pytorch_geometric/blob/master/examples/pytorch_lightning/graph_sage.py#L72

Best,
T.C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant